Django

Code

Ticket #10659 (new)

Opened 1 year ago

Last modified 1 year ago

Properly handle Paste's MultiDict and UnicodeMultiDict in Django Form's SelectMultiple

Reported by: amaslov Assigned to: nobody
Milestone: Component: Forms
Version: 1.0 Keywords:
Cc: Triage Stage: Design decision needed
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

We are using Django Forms with Pylons and improper handling of Paste's MultiDict? objects in SelectMultiple?.value_from_datadict is quite inconvenient. The fix is trivial - see the attached diff. Please add this to the trunk if possible. Thanks!

Attachments

widgets.diff (0.6 kB) - added by amaslov on 03/30/09 06:25:33.

Change History

03/30/09 06:25:33 changed by amaslov

  • attachment widgets.diff added.

04/02/09 10:00:25 changed by jacob

  • needs_better_patch changed.
  • stage changed from Unreviewed to Design decision needed.
  • needs_tests changed.
  • needs_docs changed.

This is a tricky one: I want to be able to support Paste here, but at the same time we can't possibly support every derivation of a dict that might get passed down into that function.

04/06/09 09:47:12 changed by amaslov

I think I understand the issue from your point of view. I guess the simplest way to resolve this would be to apply the patch and if somebody else comes up with the 3rd dictionary type to support - add an abstraction. Since I have been the first one to require this functionality since the beginning - there's a great chance there will be no more such weirdos :).

Add/Change #10659 (Properly handle Paste's MultiDict and UnicodeMultiDict in Django Form's SelectMultiple)




Change Properties
Action