Validation fails in spanish localflavor ESIdentityCardNumberField

Not ready for checkin - requires tests (regressiontests/localflavor/es)

Regressions Tests

Please don't mark you own tickets/patches as ready for checkin. As you can see, there are problems that show up in the review and skipping that step isn't a good idea. Just leave the ticket as "accepted" and it will be reviewed in due course.

Please create a single patch containing all the changes so that they can be reviewed in one pass and we don't have to work out which patches need to be applied (particularly if more changes occur before this is applied).

patch and regressiontests in same file.

The 'T' letter is not a valid cif/nif. References: http://es.wikipedia.org/wiki/NIF http://es.wikipedia.org/wiki/C%C3%B3digo_de_identificaci%C3%B3n_fiscal http://es.wikipedia.org/wiki/NIE

Furthemore... to support the XYZ the algorithm must be changed. An '0' (for X), '1' (for the Y), '2' (for Z) should be added at the beggining of the number before the casting to int.

Replying to meaksh:

The spanish localflavor ESIdentityCardNumberField accepts the syntax of the spanish official cards type, but due the new revision of the law (http://www.boe.es/boe/dias/2008/07/15/pdfs/A30880-30880.pdf), it need to be updated.

I've been searching about the 'T'... It looks that is used (or has been used) for foreigners when the number in their country match the format of the spanish number.

"La ley establece que el NIF, en caso de personas físicas extranjeras con documentación del pais de origen podrá sustituirse por el número de identidad válido en su país de origen, precedido por una T. Por tanto y de cara a la validación: TODO NIF QUE COMIENCE POR T ES VÁLIDO, dado que el resto del NIF se rige de acuerdo a la legislación propia de cada país"

But I have not found official documentation. So, the validation of that number is not possible because the algorithm is not the spanish one. A decision must be taken in order to support T numbers. Furthemore, the T is treated as an X, what is wrong.

In theory a valid T NIE would be a T followed by 8 characters in the set [A-Z0-9].

An alternative (and right) patch

I just added another patch. I included the code to support YZ NIE types and supressed the T as a NIE type. I don´t think that a NIE T type will appear, is so a new ticket can be opened. I think that the T type should not be consider (anyway the implementation was wrong as a checking should not be done for the T type).