Django

Code

Ticket #10184 (closed: fixed)

Opened 1 year ago

Last modified 11 months ago

pickled QueryDicts lose multiple-values.

Reported by: Andre LeBlanc <andrepleblanc@gmail.com> Assigned to: Alex
Milestone: 1.1 Component: HTTP handling
Version: SVN Keywords: QueryDict pickle session
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Pickling a querydict with multiple values for the same key causes it to only retain the one of its values. attached a patch against tests/regressiontests/httpwrappers/tests.py including a new test to pickle multi-valued querydicts which fails on latest SVN.

Attachments

querydict_test.patch (0.6 kB) - added by Andre LeBlanc <andrepleblanc@gmail.com> on 02/03/09 12:08:28.
QueryDict? test
querydict-pickle.diff (2.1 kB) - added by Alex on 02/03/09 12:47:19.
querydict-pickle.2.diff (2.0 kB) - added by Alex on 02/20/09 11:49:20.
fixed issue, removed dead code
querydict-pickle.3.diff (2.0 kB) - added by Alex on 03/30/09 15:43:46.

Change History

02/03/09 12:08:28 changed by Andre LeBlanc <andrepleblanc@gmail.com>

  • attachment querydict_test.patch added.

QueryDict? test

02/03/09 12:47:19 changed by Alex

  • attachment querydict-pickle.diff added.

02/03/09 14:12:22 changed by Alex

  • needs_better_patch changed.
  • needs_tests changed.
  • owner changed from nobody to Alex.
  • needs_docs changed.
  • has_patch set to 1.
  • stage changed from Unreviewed to Accepted.

02/20/09 11:49:20 changed by Alex

  • attachment querydict-pickle.2.diff added.

fixed issue, removed dead code

03/30/09 10:16:02 changed by Alex

  • milestone set to 1.1.

03/30/09 15:43:46 changed by Alex

  • attachment querydict-pickle.3.diff added.

03/30/09 16:42:38 changed by jacob

  • stage changed from Accepted to Ready for checkin.

03/31/09 00:14:13 changed by jacob

  • status changed from new to closed.
  • resolution set to fixed.

(In [10240]) Fixed #10184: QueryDicts? with multiple values can now be safely pickled. Thanks, Alex Gaynor.

03/31/09 14:34:09 changed by jacob

(In [10279]) [1.0.X] Fixed #10184: QueryDicts? with multiple values can now be safely pickled. Thanks, Alex Gaynor.

Backport of [10240] from trunk.

Add/Change #10184 (pickled QueryDicts lose multiple-values.)




Change Properties
Action