#10109 closed (fixed)
Move raw sql from models.fields.related to models.sql.query
| Reported by: | David Larlet | Owned by: | Alex Gaynor |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | 1.0 |
| Severity: | Keywords: | ||
| Cc: | artagnon, Jannis Leidel, Sergey Belov | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Otherwise backends which do not rely on sql can't use many-to-many relations as discussed here:
http://groups.google.com/group/django-developers/browse_thread/thread/c3cd2eb4f63aed5d/6e8de9e05424d18f
(do not care with messages from people that doesn't know how to use reply-to on mailing-lists)
Now let's discuss around the proposed patch.
Attachments (5)
Change History (18)
by , 16 years ago
| Attachment: | patch_django_10109.20090123.diff added |
|---|
comment:1 by , 16 years ago
| Needs documentation: | set |
|---|---|
| Needs tests: | set |
comment:2 by , 16 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
This needs to happen as part of a bigger refactor of related fields.
comment:3 by , 16 years ago
| Cc: | added |
|---|
comment:4 by , 16 years ago
Noting here that this(or some variant thereof) is going to be a blocker on having many to many fields work correctly with Multiple Database support(GSOC).
comment:5 by , 16 years ago
| Owner: | changed from to |
|---|
For the record:
[15:43] <Alex_Gaynor> david`bgk: bitchin! There's probably no time for that to go in before 1.1. But if you remind me I'll bug the shit out of jacobkm and russ to get it in fterwords
I'll ping you anyway.
comment:7 by , 15 years ago
| Cc: | added |
|---|
comment:8 by , 15 years ago
| Cc: | added |
|---|
by , 15 years ago
| Attachment: | m2m-refactor.r11683.diff added |
|---|
RC1 of the m2m refactor stemming from Alex's GSoC 2009 project
comment:9 by , 15 years ago
The patch I have just uploaded is ready for trunk. The code is also available on Alex Gaynor's github branch
My intention is to commit this mid next week. Feedback is welcome.
comment:10 by , 15 years ago
| milestone: | → 1.2 |
|---|---|
| Needs documentation: | unset |
| Needs tests: | unset |
by , 15 years ago
| Attachment: | m2m-refactor.r11683.2.diff added |
|---|
RC2 of m2m-refactor patch. Incorporates fix for abstract base classes.
comment:11 by , 15 years ago
Another small issue: Intermediary models should have 'unique_together': (from_, to), to match the old behaviour.
by , 15 years ago
| Attachment: | m2m-refactor.r11705.diff added |
|---|
RC3 for m2m-refactor patch. Incorporates unique_together fix.
comment:12 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Initial patch, without any documentation nor tests, design discussion for now