call_command doesn't take into account command's default options

[Alexander Koshelev]

When I want to use manage.py command from python I must specify all options on which this command is depend.

Almost everyone custom command's author write execute method something like this:

class Command(BaseCommand):
    option_list = [make_option("--some_option", default="foobar")]

    def execute(self, *args, **options):
        #...
        some_option = options["some_option"]
        #...

And when I call it using call_command without some_option is specified I get the KeyError. But it works fine in command line because optparse provides default values.

>>> call_command("some_command")
Traceback (most recent call last):
...
KeyError: 'some_option'

Patch solves this inconsistence.

[Alexander Koshelev]

Patch

[(none)]

Milestone post-1.0 deleted

[Jacob]

(In [10401]) [1.0.X] Fixed #10080: call_command now takes option defaults into account, sparing individual commands from any difference between call_command and being run from the shell. Thanks, Alex Koshelev. Backport of 10400 from trunk.

[bjourne]

The patch solves the problem if the option has a default value, it still doesn't work if no default value is specified. In those cases, optparse sets the options value to None but call_command plainly excludes it which leads to problems with some commands. This update makes it work for me:

    defaults = {}
    for o in klass.option_list:
        v = o.default
        if v is NO_DEFAULT:
            v = None
        defaults[o.dest] = v

[Claude Paroz]

Also fill defaults dict with options without defaults

[Jannis Leidel]

In [17467]:

Fixed #10080 -- Slightly extended the fix made in r10401 by also taking command line options into account that don't have have a default set. Thanks, Claude Paroz.

[Ramiro Morales]

In [17678]:

Fixed #17820 -- Fixed more occurrences of redundant handling of management commands options.

They had been missen in the first attempts or had been introduced afterwards.

Refs #13760, #10080, #17799.