auth.forms.PasswordResetForm.clean_email returns None

[Zak Johnson <zakj@…>]

Classes inheriting from PasswordResetForm will be unable to access self.cleaned_data['email'] without a stub clean_email() to return a value:

    def clean_email(self):
        super(MyPasswordResetForm, self).clean_email()
        return self.cleaned_data['email']

[glund@…]

Seems an obvious bug; it just caused us problems - setting to Accepted, I'd suggest this is ready for checkin?

[Russell Keith-Magee]

Not ready for checkin - requires a test (django/contrib/auth/tests/forms.py). There aren't any tests for the PasswordResetForm at the moment (which is probably why this bug slipped through the cracks), but that's no excuse for not adding them when we have the chance.

[Luke Plant]

Note that there are tests for the password reset views, and for the PasswordResetTokenGenerator, so in the tests for the PasswordResetForm the scope can be kept nice and narrow (i.e. I wouldn't worry about testing the 'save' method).

[Leo Shklovskii]

I've attached several (possibly gratuitous) tests for PasswordResetForm, including one for this bug.

This would be fantastic to get checked in.

[Luke Plant]

(In [9906]) Fixed #10017 - PasswordResetForm.clean_email was not returning the value.

Thanks Zak Johnson, Leo

[Luke Plant]

(In [9907]) [1.0.X] Fixed #10017 - PasswordResetForm.clean_email was not returning the value.

Thanks Zak Johnson, Leo

Backport of r9906 from trunk.