Code

Changes between Version 12 and Version 13 of ContributingHowTo


Ignore:
Timestamp:
11/17/10 14:48:55 (3 years ago)
Author:
gabrielhurley
Comment:

added example workflow

Legend:

Unmodified
Added
Removed
Modified
  • ContributingHowTo

    v12 v13  
    4747 * '''Fixed on a branch''': Used to indicate that a ticket is resolved as part of a major body of work that will eventually be merged to trunk. Tickets in this stage generally don't need further work. This may happen in the case of major features/refactors in each release cycle, or as part of the annual Google Summer of Code efforts. 
    4848 
     49Here's an example workflow: 
     50 
     51 * Alice creates a ticket, and uploads an incomplete patch (no tests, incorrect implementation). 
     52 * Bob reviews the patch, marks it "Accepted", "needs tests", and "patch needs improvement", and leaves a comment telling Alice how the patch could be improved. 
     53 * Alice updates the patch, adding tests (but not changing the implementation). She removes the two flags.  
     54 * Charlie reviews the patch and resets the 'patch needs improvement flag' with another comment about improving the implementation. 
     55 * Alice updates the patch, fixing the implementation. She removes the "patch needs improvement" flag.  
     56 * Daisy reviews the patch, and marks it RFC. 
     57 * Jacob reviews the RFC patch, applies it to his checkout, and commits it. 
     58 
    4959=== Advice for new contributors === 
    5060