Timeline


and

03/21/10:

22:14 Ticket #13176 (Provide finer control over table name conventions) closed by russellm
wontfix: I'm going to mark this wontfix. If you are adopting a framework, at …
22:06 Ticket #13177 (Unescaped user input in the Admin interface) created by nomulous
Steps to reproduce: 1. Go into the Django User Admin interface 2. Open …
20:55 Ticket #13176 (Provide finer control over table name conventions) created by ejm
This is a suggestion about database table names and the way they are …
20:53 Ticket #13175 ("+ Add another [...]" bug with final_attrs['id']) created by rasca
When adding a new inline in the admin through "+ Add another […]" …
20:51 Ticket #13022 (when saving a model with m2m field in the admin, 'clear' and 'add' ...) closed by russellm
wontfix: Hyperbole will get you nowhere. The current behavior doesn't render …
20:04 Ticket #13174 (readonly_fields in StackedInline forms in the admin are missing the ...) created by benc
readonly_field in StackedInline forms in the admin are missing the …
19:50 Ticket #13173 (entire admin_scripts test suite fails on Windows if sys.executable ...) created by gabrielhurley
This is an edge case to be sure, but it sure is annoying if you have …
15:54 Changeset [740c974]stable/1.1.x by Karen Tracey <kmtracey@…>
[1.1.X] Fixed #12822: Don't copy the _aggregate_select_cache when …
15:47 Changeset [9df71371]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Karen Tracey <kmtracey@…>
Fixed #12822: Don't copy the _aggregate_select_cache when cloning a …
15:47 Ticket #12822 (DatabaseError: aggregates not allowed in WHERE clause) closed by kmtracey
fixed: (In [12830]) Fixed #12822: Don't copy the _aggregate_select_cache when …
15:35 Ticket #12286 (Table for Model that has been proxied may not be created) closed by kmtracey
fixed: (In [12829]) [1.1.X] Fixed #12286: Ensure proxied model's table is …
15:35 Changeset [3a55a2f4]stable/1.1.x by Karen Tracey <kmtracey@…>
[1.1.X] Fixed #12286: Ensure proxied model's table is created. Thanks …
15:29 Changeset [72ea8fc4]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Karen Tracey <kmtracey@…>
Refs: #12286 -- Add a test to verify that a proxied model's table is …
15:13 Ticket #13172 (multiple_database test failure after changeset 12755) closed by gabrielhurley
invalid
15:08 Ticket #3381 ([PATCH] make manage.py read PYTHONSTARTUP) reopened by vak
Not all seem to be happy with ipython. Just visit #python to get more …
13:33 Ticket #13022 (when saving a model with m2m field in the admin, 'clear' and 'add' ...) reopened by halldor89
Even though the current behavior might be intended it does render the …
12:18 Ticket #13172 (multiple_database test failure after changeset 12755) created by gabrielhurley
I'm getting a failure from the …
11:55 Ticket #13171 (field_subclassing test failing, needs to use get_prep_lookup) created by gabrielhurley
I ran the full unit test suite this morning (Windows, SQLite3), and …
09:23 Ticket #13004 (The new get_readonly_fields() method of the ModelAdmin breaks with ...) closed by kmtracey
fixed: (In [12827]) Fixed #13004: Ensure the add page for a model with a …
09:23 Changeset [f88c2f1]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Karen Tracey <kmtracey@…>
Fixed #13004: Ensure the add page for a model with a ManyToManyField …
08:47 Ticket #13170 (messages set_level AttributeError) closed by kmtracey
fixed: (In [12826]) Fixed #13170: Make get_level and set_level importable …
08:47 Changeset [8661cb9b]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Karen Tracey <kmtracey@…>
Fixed #13170: Make get_level and set_level importable from …
04:16 Ticket #13170 (messages set_level AttributeError) created by dm
I have the following views.py file: […] When I use this view, I …
00:13 Ticket #13169 (Some templates in templates_folder/registration used by contrib.admin) closed by russellm
invalid: Trac is for registering confirmed bugs, not for asking "how" or "why" …
00:10 Ticket #13169 (Some templates in templates_folder/registration used by contrib.admin) created by peyman
Problem = trying to access …

03/20/10:

22:47 Ticket #13168 (inline-group css class in admin should have text-align:right when in rtl) created by benc
The h2 header of an inline block in the admin should have …
20:54 Ticket #12778 (InlineAdmin ignores inner Media class) closed by jezdez
fixed: (In [12825]) Fixed #12778 - Added media handling abilities to admin …
20:54 Changeset [3f4fef43]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Jannis Leidel <jannis@…>
Fixed #12778 - Added media handling abilities to admin inlines. Thanks …
15:31 Changeset [df010f0]stable/1.1.x by Karen Tracey <kmtracey@…>
[1.1.X] Fixed #12554: Silence exceptions that have specified …
15:27 Ticket #12554 (silent_variable_failure not suppressing exception during dict lookup) closed by kmtracey
fixed: (In [12823]) Fixed #12554: Silence exceptions that have specified …
15:27 Changeset [2403f58]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Karen Tracey <kmtracey@…>
Fixed #12554: Silence exceptions that have specified …
15:11 Changeset [d5336b22]stable/1.1.x by Karen Tracey <kmtracey@…>
[1.1.X] Fixed #12239, again: Refined the original fix to avoid the …
15:01 Ticket #12239 (Float is rounded to integer on queries on integer field) closed by kmtracey
fixed: (In [12821]) Fixed #12239, again: Refined the original fix to avoid …
15:01 Changeset [10884ec]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Karen Tracey <kmtracey@…>
Fixed #12239, again: Refined the original fix to avoid the test errors …
14:39 Ticket #13167 (Non-existent arg passed to template filter raises VariableDoesNotExist) created by copelco
Branched from #12554. …
14:24 Ticket #12962 (Broken Admin Delete Action With Confirmation) closed by blinkylights
fixed: Closing this ticket and opening #13166 to handle action/list_editable …
13:20 Ticket #12239 (Float is rounded to integer on queries on integer field) reopened by kmtracey
Fix here broke some other tests: […]
13:11 Ticket #13166 (Admin change view: ambiguity between action and list_editable form ...) created by blinkylights
The Admin change view can have two simultaneous form interactions if …
13:04 Changeset [8badb75]stable/1.1.x by Karen Tracey <kmtracey@…>
[1.1.X] Fixed #12239: Fixed results of gte and lt queries when …
12:57 Ticket #12962 (Broken Admin Delete Action With Confirmation) reopened by blinkylights
I have another patch that covers cases where the user might change …
12:56 Changeset [9150fb6b]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Karen Tracey <kmtracey@…>
Fixed #12239: Fixed results of gte and lt queries when comparing …
12:56 Ticket #12239 (Float is rounded to integer on queries on integer field) closed by kmtracey
fixed: (In [12819]) Fixed #12239: Fixed results of gte and lt queries when …
11:55 1.2ReleaseCandidateSprint edited by bmihelac
(diff)
10:50 Ticket #11606 (return error data when using only() and select_related() at the same ...) closed by russellm
duplicate: Duplicate of #12851, fixed in r12817.
10:42 Changeset [4d00ac8]stable/1.1.x by Russell Keith-Magee <russell@…>
[1.1.X] Fixed #12851 -- Corrected the interaction of defer() with …
10:37 Ticket #12851 (Queryset "defer" won't work properly with select_related) closed by russellm
fixed: (In [12817]) Fixed #12851 -- Corrected the interaction of defer() with …
10:37 Changeset [3a5dae5e]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Russell Keith-Magee <russell@…>
Fixed #12851 -- Corrected the interaction of defer() with …
10:26 Ticket #13054 (integer part grouping settings does not respect USE_L10N setting ...) closed by jezdez
fixed: (In [12816]) Fixed #13054 - Only apply grouping to integer part of …
10:26 Changeset [10d4094]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Jannis Leidel <jannis@…>
Fixed #13054 - Only apply grouping to integer part of numbers if …
10:23 Changeset [eb1c7b03]stable/1.1.x by Karen Tracey <kmtracey@…>
[1.1.X] Fixed #12707. Admin action messages are no longer displayed …
10:03 Ticket #12937 (Select related() not working as of Beta) closed by russellm
fixed: (In [12814]) Fixed #12937 -- Corrected the operation of …
10:02 Changeset [bfa080f4]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Russell Keith-Magee <russell@…>
Fixed #12937 -- Corrected the operation of select_related() when …
09:53 Ticket #12962 (Broken Admin Delete Action With Confirmation) closed by kmtracey
fixed: (In [12813]) Fixed #12962: Made admin delete action work again. Thanks …
09:53 Changeset [4528f398]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Karen Tracey <kmtracey@…>
Fixed #12962: Made admin delete action work again. Thanks ptone, …
08:37 Sprints edited by tobias
adding 1.2 RC sprint (diff)
07:30 Changeset [32134986]stable/1.1.x by Russell Keith-Magee <russell@…>
[1.1.X] Fixed #12850 -- Ensured that constraint names are quoted when …
07:29 Changeset [4f98a7c]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Russell Keith-Magee <russell@…>
Fixed #12850 -- Ensured that constraint names are quoted when they are …
07:29 Ticket #12850 (db constraint identifiers are not quoted consistantly, so are not case ...) closed by russellm
fixed: (In [12811]) Fixed #12850 -- Ensured that constraint names are quoted …
05:37 Ticket #13156 (exists() selects all columns) closed by russellm
fixed: (In [12810]) Fixed #13156 -- Ensure that exists() queries are as fast …
05:37 Changeset [9f6a82fa]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Russell Keith-Magee <russell@…>
Fixed #13156 -- Ensure that exists() queries are as fast as they can …
04:03 Ticket #13165 (Display edit link beside add button for ForeignKey fields in admin) created by DrMeers
The reciprocal of #13163 -- when a ForeignKey field is rendered in …
03:29 1.2ReleaseCandidateSprint edited by anonymous
(diff)
01:00 Ticket #13155 (Iteration of a Many To Many Relationship raises Field Error) closed by russellm
duplicate: I'm going to call this a strange presentation of #10405. If I'm …
00:04 Changeset [6943950d]stable/1.1.x by Justin Bronn <jbronn@…>
[1.1.X] Fixed fieldlookup docs cross-reference directive, and added …
00:04 Changeset [d58020fc]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Justin Bronn <jbronn@…>
Fixed fieldlookup docs cross-reference directive, and added it to …

03/19/10:

23:53 Ticket #13151 (If ADMIN_MEDIA_PREFIX is not assigned, things don't ...) closed by kmtracey
wontfix: That's what a default is: the value that is assigned to a variable if …
22:53 Ticket #13151 (If ADMIN_MEDIA_PREFIX is not assigned, things don't ...) reopened by mlissner
It's not met b/c the documentation doesn't say that if the variable …
22:47 Ticket #13153 (An rpm fails to build with python setup.py bdist_rpm) closed by russellm
duplicate
22:47 Ticket #12634 (sql compiler execute: fetchone empty result with ordering_aliases fail.) closed by russellm
invalid: Again, closing invalid. Unless you can provide a query that invokes …
22:38 Ticket #13151 (If ADMIN_MEDIA_PREFIX is not assigned, things don't ...) closed by russellm
wontfix: How is this requirement not met by the phrase: Be careful not to use …
22:15 Ticket #13164 (Why contrib.auth does not do the registration/signup process?) closed by russellm
invalid: Firstly, don't reopen a ticket that a core developer has closed …
22:11 Ticket #13164 (Why contrib.auth does not do the registration/signup process?) reopened by peyman
Replying to russellm: > Firstly, if you want to ask a …
21:58 Ticket #13164 (Why contrib.auth does not do the registration/signup process?) closed by russellm
invalid: Firstly, if you want to ask a question, ask on the mailing list. Trac …
21:02 Ticket #13164 (Why contrib.auth does not do the registration/signup process?) created by peyman
Why contrib.auth does not do the registration/signup process? Why do …
19:13 Ticket #13163 (Display link to change-form on inlines where model is registered in ...) created by DrMeers
If an inline object has a get_absolute_url method, a 'View on …
18:58 SchemaEvolution edited by boxed
(diff)
17:46 Ticket #13162 (Little error in "the file object" documentation) created by tyrion.mx@…
In the File object documentation ( …
16:53 Ticket #13161 (Ticked 2514 and 5171, solution for using Django with other psycopg2 ...) created by spoksss
Hi, I have some problem while I use Django connection based on …
16:06 Ticket #13151 (If ADMIN_MEDIA_PREFIX is not assigned, things don't ...) reopened by mlissner
Sorry if that was vague, umm, my suggestion is to note that if …
16:04 Ticket #13160 (Brazilian localization fixes and updates) created by Guilherme Gondim (semente) <semente@…>
14:35 DevelopersForHire edited by iscape
(diff)
13:44 Ticket #13159 (Quote aggregate alias in order by) created by davidelias
Running the aggregation tests gives an error against Firebird …
13:39 Ticket #13158 (Documentation still says to use ForeignKey with unique=True to add a ...) created by hvdklauw
The documentation says to extend the user model you should add a …
13:25 DjangoFriendlyWebHosts edited by skylar_inmotion
(diff)
12:43 Ticket #13157 (Action's select from admin site to "delete selected items" doesn't work) closed by kmtracey
duplicate: #12962 is already open for this. Please search before opening new tickets.
12:34 Ticket #13157 (Action's select from admin site to "delete selected items" doesn't work) created by support@…
I upgrade django to revision 12807 and the action's select from admin …
12:18 Ticket #13156 (exists() selects all columns) created by kmtracey
It doesn't seem like the behavior noted here: …
11:01 Ticket #13155 (Iteration of a Many To Many Relationship raises Field Error) reopened by callen
10:36 Ticket #12634 (sql compiler execute: fetchone empty result with ordering_aliases fail.) reopened by anonymous
I'm not the original submitter. But I see this error on revision 12799 …
10:32 Ticket #13155 (Iteration of a Many To Many Relationship raises Field Error) closed by kmtracey
invalid: I don't see specifics of the models in use here linked anywhere -- …
10:17 Ticket #13155 (Iteration of a Many To Many Relationship raises Field Error) created by callen
As seen here: http://gist.github.com/337546 Cannot resolve keyword …
10:15 Ticket #13154 (Make reverse() match the behavior of resolve()) created by patrys
Consider the following urls.py: […] When passed to resolve(), …
09:54 1.2ReleaseCandidateSprint edited by nessita
(diff)
04:45 Ticket #13153 (An rpm fails to build with python setup.py bdist_rpm) created by cesar@…
Two issues prevent an rpm package to be built with a python setup.py …
00:43 Changeset [9d5fb83]stable/1.1.x by Russell Keith-Magee <russell@…>
[1.1.X] Fixed #13152 -- Ensure the test client saves the session …
00:42 Changeset [f081059]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Russell Keith-Magee <russell@…>
Fixed #13152 -- Ensure the test client saves the session before …
00:42 Ticket #13152 (Test client can't log in if session engine modifies session key) closed by russellm
fixed: (In [12806]) Fixed #13152 -- Ensure the test client saves the session …
00:40 Ticket #13152 (Test client can't log in if session engine modifies session key) created by russellm
The test client login() call currently saves the session *after* …

03/18/10:

23:42 1.2ReleaseCandidateSprint edited by anonymous
(diff)
23:40 CustomImageField edited by newacct
(diff)
21:57 Ticket #13151 (If ADMIN_MEDIA_PREFIX is not assigned, things don't ...) closed by russellm
wontfix: When you start a new project, ADMIN_MEDIA_PREFIX is included in the …
20:46 Ticket #13151 (If ADMIN_MEDIA_PREFIX is not assigned, things don't ...) created by mlissner@…
I just spent about 45 minutes trying to get the instructions here to …
19:39 Ticket #13148 (DEBUG_SHOW_DJANGO_TRACEBACK) closed by russellm
duplicate: I'm going to close this as a duplicate of #11834 - We don't need an …
18:18 Ticket #13150 (Replace make_safe(media) with media in ModelAdmin context dictionary) created by lsbardel
Currently, the media object is converted to safe string in both …
17:42 Ticket #13149 (ForeignKeyRawIdWidget doesn't handle invalid values) created by acdha
#11465 added a check for values which do not exist but does not help …
17:27 Sprints edited by tobias
(diff)
17:12 Ticket #13148 (DEBUG_SHOW_DJANGO_TRACEBACK) created by haras
Hi, Recently I was doing a lot of django works and every time I get a …
15:37 Ticket #13147 (auth.UserCreationForm : unicity check on username not necessary) created by peyman
Hi, In django.contrib.auth.UserCreationForm, there is …
15:16 DjangoDesign edited by utku
(diff)
15:14 Ticket #13146 (Remove hardcoded stuff in contrib.admin) created by utku
There're lots of unnecessary hardcoded elements with the Admin which …
13:41 DjangoJobs edited by stdbrouw
hm, single-item list is tricky :-) (diff)
13:39 DjangoJobs edited by stdbrouw
small fix (diff)
13:38 DjangoJobs edited by stdbrouw
fixed a little mistake in the formatting, and added my call for … (diff)
13:15 Ticket #12836 (Model.get_absolute_url lose method attributes) reopened by carljm
This is not actually a duplicate of #11891. That ticket is about …
13:14 Ticket #11891 (The attributes of the original get_absolute_url defined in the model ...) closed by carljm
fixed: The problem here is that #12836 shouldn't have been closed as dupe in …
13:05 Ticket #13132 ([signals] Storing id()s instead of actual instances considered harmful) closed by carljm
wontfix: As documented in …
12:57 Ticket #13144 (django.template.loaders.app_directories.Loader should look in template ...) closed by carljm
wontfix: Yes you're doing this wrong. For one thing, the template system has …
12:11 Ticket #13145 (Allow the prefix used for empty_form on FormSets to be customized) created by Alex
11:28 Ticket #13144 (django.template.loaders.app_directories.Loader should look in template ...) created by betawarz
The django.template.loaders.app_directories.Loader template loader …
11:17 Ticket #13123 (Extra params + aggregation creates incorrect SQL.) closed by Alex
duplicate: But it's still a dupe(I couldn't change the resolution).
11:17 Ticket #13123 (Extra params + aggregation creates incorrect SQL.) reopened by Alex
This is almost certainly the wrong ticket.
10:59 Ticket #13132 ([signals] Storing id()s instead of actual instances considered harmful) reopened by anonymous
> The whole sender framework is supposed to be identifying the …
10:37 Ticket #13124 (function 'find_template_loader' doesn't work with PyPy 1.2) closed by russellm
fixed: (In [12805]) Fixed #13123 -- Cleaned up template loader for PyPy
10:35 Changeset [003fe52]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Russell Keith-Magee <russell@…>
Fixed #13123 -- Cleaned up template loader for PyPy compatibility. …
10:22 Changeset [10de2a83]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Russell Keith-Magee <russell@…>
Fixed #13030 -- Corrected natural key deserialization to subclasses. …
10:22 Ticket #13030 (Natural Key deserialization fails on foreign key to field that is ...) closed by russellm
fixed: (In [12804]) Fixed #13030 -- Corrected natural key deserialization to …
08:24 Ticket #12849 (django's development server raises an encoding exception when trying ...) closed by russellm
fixed: (In [12803]) Fixed #12849 -- Corrected the way strings are encoded for …
08:24 Changeset [be8a1f6]soc2010/app-loadingsoc2010/query-refactorsoc2010/test-refactorstable/1.2.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.x by Russell Keith-Magee <russell@…>
Fixed #12849 -- Corrected the way strings are encoded for display by …
07:17 Ticket #13143 (filter_horizontal & filter_vertical widgets does not work if ...) closed by russellm
invalid: This is an unusual presentation, but the issue here is that you have …
07:06 Ticket #13143 (filter_horizontal & filter_vertical widgets does not work if ...) created by EkremSEREN
filter_horizontal & filter_vertical widgets does not work if …
06:59 Ticket #13132 ([signals] Storing id()s instead of actual instances considered harmful) closed by russellm
wontfix: I'm going to close this wontfix. "If in doubt, use a string" isn't …
05:25 Ticket #13142 (Add support for SSL connections in core.mail.backends.smtp) created by serg.partizan@…
Current code for smtp backend dont allow using SSL connections to mail …
04:57 Ticket #13141 (ModelForm can't update model like the way it is documented) closed by russellm
worksforme: If don't know what's going on here. ModelForm saving is a fairly …
04:41 Ticket #13141 (ModelForm can't update model like the way it is documented) created by CNBorn
I want to update a model from a modelform, In a view that handling …
01:59 Ticket #13140 (Test client doesn't pass **extra to _handle_redirects) created by dpn
Hey. This problem occurs when using the test client in follow=True …
01:35 Ticket #11891 (The attributes of the original get_absolute_url defined in the model ...) reopened by minmax
copy & paste from #12836 […]
01:27 Ticket #11891 (The attributes of the original get_absolute_url defined in the model ...) closed by ubernostrum
fixed: The fix in [12766] included unit tests to check that this works, and …
Note: See TracTimeline for information about the timeline view.
Back to Top