﻿id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
9588	provide **kwargs argument to GenericInlineModelAdmin.get_formset	lakin@…	Brian Rosner	"InlineModelAdmin.get_formset provides kwargs to override defaults:
{{{
    def get_formset(self, request, obj=None, **kwargs):
        """"""Returns a BaseInlineFormSet class for use in admin add/change views.""""""
        if self.declared_fieldsets:
            fields = flatten_fieldsets(self.declared_fieldsets)
        else:
            fields = None
        if self.exclude is None:
            exclude = []
        else:
            exclude = self.exclude
        defaults = {
            ""form"": self.form,
            ""formset"": self.formset,
            ""fk_name"": self.fk_name,
            ""fields"": fields,
            ""exclude"": exclude + kwargs.get(""exclude"", []),
            ""formfield_callback"": self.formfield_for_dbfield,
            ""extra"": self.extra,
            ""max_num"": self.max_num,
        }
        defaults.update(kwargs)
        return inlineformset_factory(self.parent_model, self.model, **defaults)
}}}

Shouldn't we do the same for GenericInlineModelAdmin.get_formset ?

Potential Patch: 
{{{
    def get_formset(self, request, obj=None, **kwargs):
        if self.declared_fieldsets:
            fields = flatten_fieldsets(self.declared_fieldsets)
        else:
            fields = None
        defaults = {
            ""ct_field"": self.ct_field,
            ""fk_field"": self.ct_fk_field,
            ""form"": self.form,
            ""formfield_callback"": self.formfield_for_dbfield,
            ""formset"": self.formset,
            ""extra"": self.extra,
            ""can_delete"": True,
            ""can_order"": False,
            ""fields"": fields,
        }
        defaults.update(kwargs)
        return generic_inlineformset_factory(self.model, **defaults)
}}}

I chose the ""Contrib Apps"" component because there is no ""contrib.contenttypes""."	New feature	closed	contrib.contenttypes	dev	Normal	fixed			Ready for checkin	1	0	0	0	0	0
