id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
8479	Race condition in core.files.storage.py, leads to crash	aubonbeurre	nobody	"This seems related to #4948, but not quite, so I opened a new ticket.

Line 148:

                # This file has a file path that we can move.
                if hasattr(content, 'temporary_file_path'):
                    file_move_safe(content.temporary_file_path(), full_path)
                    content.close()

This should be inverted:

                # This file has a file path that we can move.
                if hasattr(content, 'temporary_file_path'):
                    content.close()
                    file_move_safe(content.temporary_file_path(), full_path)

The code throws an exception, because it ends-up to copy-then-delete, since in my particular case src and dest are not on the same file system.

It will fail on Windows, and I suspect this is particular to NTFS (although I did not test on other platforms): it is not possible to remove an opened file.

"		closed	File uploads/storage	dev		duplicate			Unreviewed	1	0	0	0	0	0