id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
7120	django.contrib.admin.sites uses User but doesn't import it	Maciej Wiśniowski	nobody	"django.contrib.admin.sites has no import of User model but uses it:

This fragment uses User object:
{{{
            if u'@' in username:
                # Mistakenly entered e-mail address instead of username? Look it up.
                try:
                    user = User.objects.get(email=username)
                except User.DoesNotExist:
                    message = _(""Usernames cannot contain the '@' character."")
                else:
                    message = _(""Your e-mail address is not your username. Try '%s' instead."") % user.username
}}}

But in fact it causes error:
{{{
File ""/usr/lib/python2.5/site-packages/django/contrib/admin/sites.py"", line 226, in login
NameError: global name 'User' is not defined
}}}

Simple import:
{{{
    from django.contrib.auth.models import User
}}}

should be added."		closed	contrib.admin	newforms-admin		worksforme	sites user import		Unreviewed	0	0	0	0	0	0