﻿id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
6307	Creating new related object through popup interface in admin can produce JavaScript error	Webchemist	nobody	"I got an JavaScript error when trying to create an related object through popup window in django admin

Django version: 0.97-newforms-admin-SVN-6991
Error: text.replace is not a function
Source: http://127.0.0.1:8000/admin-media/js/admin/RelatedObjectLookups.js
Line: 6

This error is produced in this function:

{{{
function dismissAddAnotherPopup(win, newId, newRepr) {
    // newId and newRepr are expected to have previously been escaped by
    // django.utils.html.escape.
    newId = html_unescape(newId);
    newRepr = html_unescape(newRepr);
    var name = win.name.replace(/___/g, '.');
    var elem = document.getElementById(name);
    if (elem) {
        if (elem.nodeName == 'SELECT') {
            var o = new Option(newRepr, newId);
            elem.options[elem.options.length] = o;
            o.selected = true;
        } else if (elem.nodeName == 'INPUT') {
            elem.value = newId;
        }
    } else {
        var toId = name + ""_to"";
        elem = document.getElementById(toId);
        var o = new Option(newRepr, newId);
        SelectBox.add_to_cache(toId, o);
        SelectBox.redisplay(toId);
    }
    win.close();
}
}}}

It is need to change the lines (call toString() method for every entering value, because here a string expected):

{{{
    ....
    newId = html_unescape(newId.toString());
    newRepr = html_unescape(newRepr.toString());
    ....
}}}
"		closed	contrib.admin	newforms-admin		duplicate	popup		Accepted	1	0	0	0	0	0
