Changes between Initial Version and Version 3 of Ticket #4476

09/08/2007 12:24:38 AM (12 years ago)
Russell Keith-Magee

I'm not a fan of assertRedirectContains, because it sounds like start of aggregating groups of tests together. It works for a single redirect, but then you have a page that redirects to a redirect, so you need to add 'assertRedirectRedirectContains', and then the madness starts :-). So, -1 to the literal idea.

However, I'm going to mark the ticket is as accepted and change the summary, because the general problem is valid.

Rather than assertRedirectContains, I'm going to suggest that the test Client should be modified to do what a normal web client will do - follow redirect trails. So, if you had a site with:

/first -> redirects to /second /second -> redirects to /final /final -> a page of content

response = client.get('/first', follow=True)

you would get back the content at '/final', with a response code of 200. The response should also have some extra meta-data to indicate the paths that were visited along the way. There may also be a need to modify the assertions to allow for checking that a redirect occurred; e.g.,

assertContains(response, "content of /final", count=1, status_code=200, redirected=True)

However, I'll leave the details of any assertion changes as a detail for the implementer.


  • Ticket #4476

    • Property Owner changed from Jacob to Adrian Holovaty
    • Property Summary changed from Proposal for assertRedirectContains to Modify test client to follow redirect chains
    • Property Component changed from Uncategorized to Unit test system
    • Property Triage Stage changed from Unreviewed to Accepted
  • Ticket #4476 – Description

    initial v3  
    1717I'm assuming there's no other shortcut I'm missing.
     19*** UPDATE (from russellm) ***
     21Rather that assertRedirectContains, I'm favouring a modification to the test client that will follow redirects. Details in the comment below
Back to Top