id summary reporter owner description type status component version severity resolution keywords cc stage has_patch needs_docs needs_tests needs_better_patch easy ui_ux
37463 legend_tag() can double-render a required_css_class (attrs mutation) Jacob Walls Jacob Walls "We have a minor regression with `legend_tag()` from 0eec2a163a4b2ea4e82c53ae1d7b71bf43ac911d. We just need to not mutate any `attrs` that are passed so we don't get double-rendering in some cases:
{{{#!py
def test_legend_has_required_css_class_multiple_render(self):
class SomeForm(Form):
required_css_class = ""required""
field = CharField(max_length=10)
f = SomeForm({""field"": ""test""})
attrs = {""class"": ""foo""}
self.assertHTMLEqual(
f[""field""].legend_tag(attrs=attrs),
'',
)
self.assertHTMLEqual(
f[""field""].legend_tag(attrs=attrs),
'',
)
}}}
{{{#!py
FAIL: test_legend_has_required_css_class_multiple_render (forms_tests.tests.test_forms.FormsTestCase.test_legend_has_required_css_class_multiple_render)
----------------------------------------------------------------------
Traceback (most recent call last):
File ""/Users/jwalls/django/tests/forms_tests/tests/test_forms.py"", line 3989, in test_legend_has_required_css_class_multiple_render
self.assertHTMLEqual(
~~~~~~~~~~~~~~~~~~~~^
f[""field""].legend_tag(attrs=attrs),
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
'',
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
)
^
AssertionError: !=
-