id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
35918	SQLCompiler.execute_sql result_type CURSOR usage can be minimized	Raphael Gaschignard	Raphael Gaschignard	"(This refactor is motivated by an ongoing experiment to integrate async cursor work into the ORM, by simplifying some cursor management)

In `django.cdb.models.sql.compiler.Compiler.execute_sql`, we can pass in the following result types: `SINGLE`, `MULTI`,  `NO_RESULTS`, and `CURSOR`.

`execute_sql`'s docstring to that effect does not reflect this.

- `SINGLE` returns a single row. It closes the cursor it uses to query.
- `MULTI` returns many rows (wrapped in a cursor iterator). This either closes the cursor it uses to query, or returns an iterator that takes ownership of the cursor to close the cursor once reading of all the results are done.
- `NO_RESULTS` returns nothing. It closes the cursor it uses to query.
- `CURSOR` returns the cursor, without closing the cursor, effectively making the caller in charge of closing the cursor


`CURSOR` returns an unclosed cursor that has to be manage by the caller. In practice, though, apart from a single test usage, Django's codebase currently only uses `CURSOR` to do one thing: get the number of rows, then close the cursor.

To simplify cursor resource management, I have a two-pronged proposal:
- a new result type, `ROW_COUNT`, returns the rows and closes the cursor for you. This covers all non-test usage of `CURSOR` in Django currently.
- `CURSOR` is renamed to `LEAK_CURSOR`, as a way to more strongly indicate that you are now in charge of the cursor

Main point here is to reduce the number of places an open cursor might come into play.
"	Cleanup/optimization	assigned	Database layer (models, ORM)	dev	Normal			Raphael Gaschignard	Unreviewed	0	0	0	0	0	0