Opened 2 months ago
Closed 5 weeks ago
#34757 closed New feature (fixed)
AsyncClient should follow redirects
| Reported by: | Mike Lissner | Owned by: | Olivier Tabone |
|---|---|---|---|
| Component: | Testing framework | Version: | 4.2 |
| Severity: | Normal | Keywords: | async |
| Cc: | Carlton Gibson, Andrew Godwin | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In the documentation, it says the "AsyncClient has the same methods and signatures as the synchronous (normal) test client," except, "The follow parameter is not supported."
I searched Github and the tickets here, but couldn't find an explanation for this or a ticket discussing it. Is adding support for redirects something that's planned so that async tests of views that do redirects are possible?
Thanks as always for everything.
Change History (9)
comment:1 Changed 2 months ago by
| Cc: | Carlton Gibson Andrew Godwin added |
|---|---|
| Type: | Uncategorized → New feature |
comment:2 Changed 2 months ago by
| Triage Stage: | Unreviewed → Accepted |
|---|
Adding support for follow would required implementing an async version of _handle_redirects(). I'm not sure if it's possible.
I can't immediately see why not, so I'd say let's let someone have a pop at it. (The core loop fetching the chain of responses should work equivalently AFAICS, at a quick glance.)
comment:3 Changed 2 months ago by
| Owner: | changed from nobody to Olivier Tabone |
|---|---|
| Status: | new → assigned |
I'll have a look at this one
comment:5 Changed 6 weeks ago by
| Patch needs improvement: | set |
|---|
comment:8 Changed 5 weeks ago by
| Triage Stage: | Accepted → Ready for checkin |
|---|
Adding support for
followwould required implementing an async version of _handle_redirects(). I'm not sure if it's possible.