id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
34578	Template filter `join` should not escape the joining string if `autoescape` is `off`	Natalia Bidart	Rajeesh Punathil	"Consider the following template code snippet:

{{{
{% autoescape off %}
{{ some_list|join:some_var }}
{% endautoescape %}
}}}

in this case, the items inside `some_list` will not be escaped (matching the expected behavior) but `some_var` will forcibly be escaped. From the docs for `autoescape` or `join` I don't think this is expected behavior.

The following testcase illustrates what I think is a bug in the `join` filter (run inside the `template_tests/filter_tests` folder):
{{{
#!python
from django.template.defaultfilters import escape
from django.test import SimpleTestCase

from ..utils import setup


class RegressionTests(SimpleTestCase):

    @setup({""join01"": '{{ some_list|join:some_var }}'})
    def test_join01(self):
        some_list = [""<p>Hello World!</p>"", ""beta & me"", ""<script>Hi!</script>""]
        some_var = ""<br/>""
        output = self.engine.render_to_string(""join01"", {""some_list"": some_list, ""some_var"": some_var})
        self.assertEqual(output, escape(some_var.join(some_list)))

    @setup({""join02"": '{% autoescape off %}{{ some_list|join:some_var }}{% endautoescape %}'})
    def test_join02(self):
        some_list = [""<p>Hello World!</p>"", ""beta & me"", ""<script>Hi!</script>""]
        some_var = ""<br/>""
        output = self.engine.render_to_string(""join02"", {""some_list"": some_list, ""some_var"": some_var})
        self.assertEqual(output, some_var.join(some_list))
}}}

Result of this run in current `main` is:
{{{
.F
======================================================================
FAIL: test_join02 (template_tests.filter_tests.test_regression.RegressionTests.test_join02)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ""/home/nessita/fellowship/django/django/test/utils.py"", line 443, in inner
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File ""/home/nessita/fellowship/django/tests/template_tests/utils.py"", line 58, in inner
    func(self)
  File ""/home/nessita/fellowship/django/tests/template_tests/filter_tests/test_regression.py"", line 21, in test_join02
    self.assertEqual(output, some_var.join(some_list))
AssertionError: '<p>Hello World!</p>&lt;br/&gt;beta & me&lt;br/&gt;<script>Hi!</script>' != '<p>Hello World!</p><br/>beta & me<br/><script>Hi!</script>'

----------------------------------------------------------------------
Ran 2 tests in 0.007s
}}}"	Bug	closed	Template system	4.2	Normal	fixed			Ready for checkin	1	0	0	0	1	0