Context Navigation

← Previous Ticket
Next Ticket →

#34118 closed New feature (fixed)

Python 3.12 compatibility

Reported by:	Mariusz Felisiak	Owned by:	Mariusz Felisiak
Component:	Core (Other)	Version:	dev
Severity:	Normal	Keywords:
Cc:	bcail, David Sanders, Sam James	Triage Stage:	Accepted
Has patch:	yes	Needs documentation:	no
Needs tests:	no	Patch needs improvement:	no
Easy pickings:	no	UI/UX:	no

Description

Python 3.12 final is scheduled for October 2023 (see PEP 693). This is a tracking ticket for compatibility fixes for Django submitted in the meantime.

Django 4.2 will be the first version to support Python 3.12, because Django 4.1 will end the mainstream support in April 2023.

Change History (37)

comment:1 Changed 13 months ago by bcail

Cc:	bcail added

comment:2 Changed 13 months ago by David Sanders

Cc:	David Sanders added

comment:3 Changed 13 months ago by David Sanders

I'm getting errors on the following which was working for 3.11.0.

I'm on macos 12.6

tests main % python --version
Python 3.11.0
tests main % ./runtests.py queries.tests.Queries1Tests.test_avoid_infinite_loop_on_too_many_subqueries
Testing against Django installed in '/Users/dsanders/projects/django/django' with up to 10 processes
Found 1 test(s).
Creating test database for alias 'default'...
System check identified no issues (1 silenced).
.
----------------------------------------------------------------------
Ran 1 test in 0.295s

OK
Destroying test database for alias 'default'...


… 8< … switch venvs


tests main % python --version
Python 3.12.0a1
tests main % ./runtests.py queries.tests.Queries1Tests.test_avoid_infinite_loop_on_too_many_subqueries
Testing against Django installed in '/Users/dsanders/projects/django/django' with up to 10 processes
Found 1 test(s).
Creating test database for alias 'default'...
System check identified no issues (1 silenced).
F
======================================================================
FAIL: test_avoid_infinite_loop_on_too_many_subqueries (queries.tests.Queries1Tests.test_avoid_infinite_loop_on_too_many_subqueries)
----------------------------------------------------------------------
RecursionError: maximum recursion depth exceeded

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/dsanders/projects/django/tests/queries/tests.py", line 550, in test_avoid_infinite_loop_on_too_many_subqueries
    with self.assertRaisesMessage(RecursionError, msg):
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/contextlib.py", line 155, in __exit__
    self.gen.throw(value)
  File "/Users/dsanders/projects/django/django/test/testcases.py", line 890, in _assert_raises_or_warns_cm
    self.assertIn(expected_message, str(getattr(cm, cm_attr)))
AssertionError: 'Maximum recursion depth exceeded: too many subqueries.' not found in 'maximum recursion depth exceeded'

----------------------------------------------------------------------
Ran 1 test in 0.207s

FAILED (failures=1)
Destroying test database for alias 'default'...

Last edited 13 months ago by David Sanders (previous) (diff)

comment:4 Changed 13 months ago by bcail

Another data point: SQLite and Postgres tests pass for me on Linux with Python 3.12 alpha 1.

comment:5 Changed 13 months ago by GitHub <noreply@…>

In 67504ea5:

Refs #34118 -- Skipped not compatible requirements on daily builds for Python 3.12.

comment:6 Changed 13 months ago by GitHub <noreply@…>

In 2848e5d:

Refs #34118 -- Used smtplib's context parameter instead of keyfile and certfile.

keyfile and certfile parameters were removed in Python 3.12, see
https://github.com/python/cpython/commit/ef0e72b31d22f780d3a165d7d0471806061fe380

comment:7 Changed 12 months ago by GitHub <noreply@…>

In 32d70b2:

Refs #34118 -- Adopted asgiref coroutine detection shims.

Thanks to Mariusz Felisiak for review.

comment:8 Changed 11 months ago by GitHub <noreply@…>

In 829f4d1:

Refs #31546, Refs #34118 -- Corrected CommandTests.test_requires_system_checks_specific().

System checks are never called without skip_checks=False. Moreover,
called_once_with() is not a proper assertion and raise AttributeError
on Python 3.12.

comment:9 Changed 8 months ago by GitHub <noreply@…>

In 38e63c9:

Refs #34118 -- Fixed CustomChoicesTests.test_uuid_unsupported on Python 3.12+.

https://github.com/python/cpython/commit/2a4d8c0a9e88f45047da640ce5a92b304d2d39b1

comment:10 Changed 8 months ago by Mariusz Felisiak <felisiak.mariusz@…>

In 32cfa73c:

[4.2.x] Refs #34118 -- Fixed CustomChoicesTests.test_uuid_unsupported on Python 3.12+.

https://github.com/python/cpython/commit/2a4d8c0a9e88f45047da640ce5a92b304d2d39b1
Backport of 38e63c9e61152682f3ff982c85a73793ab6d3267 from main

comment:11 follow-up: 12 Changed 8 months ago by Sam James

Hi folks,

https://github.com/django/django/commit/38e63c9e61152682f3ff982c85a73793ab6d3267 was applied to fix Python 3.12, but cpython upstream have backported the fix for https://github.com/python/cpython/issues/102549 to Python 3.11 too.

The Django patch will need adjusting to probably just allow both output messages (or sniff the Python minor/patch version).

Last edited 8 months ago by Sam James (previous) (diff)

comment:12 in reply to: 11 Changed 8 months ago by Mariusz Felisiak

Replying to thesamesam:

Hi folks,

https://github.com/django/django/commit/38e63c9e61152682f3ff982c85a73793ab6d3267 was applied to fix Python 3.12, but cpython upstream have backported the fix for https://github.com/python/cpython/issues/102549 to Python 3.11 too.

The Django patch will need adjusting to probably just allow both output messages (or sniff the Python minor/patch version).

Thanks! It's unfortunate, will fix this.