id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
33436	Remove test_restrictions_with_no_joining_columns.	raydeal	nobody	"I am in doubt what this test exactly test: tests/foreign_object/test_empty_join.py

{{{
tests/foreign_object/test_empty_join.RestrictedConditionsTests.test_restrictions_with_no_joining_columns
}}}

The test was introduced in [https://code.djangoproject.com/ticket/25064 #25064], [https://code.djangoproject.com/ticket/27392 #27392] tickets and two more small changes in test code.

In my opinion the test doesn't test django functionality important from end user point of view or even development. It probably only test the idea of the author. Tested model, its relational fields, are fully customised not using public ORM API, just overwrite class methods.

I would suggest to delete the test because it doesn't bring an important value to django code quality."	Cleanup/optimization	closed	Database layer (models, ORM)	4.0	Normal	wontfix			Unreviewed	0	0	0	0	0	0