id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
32847	Adjust models.E025 system check for updated field descriptor setting.	Carlton Gibson	nobody	"Fix for #30427 and #16176 adjusted the way field descriptors are set when subclassing abstract models (the descriptor is now always set of child class)

This left check `models.E025` as perhaps unnecessary, or in need of replacement/adjustment. 

> **models.E025**: The property `<property name>` clashes with a related field accessor.

The original check made sure you didn't have a clash with a `@property` named for a foreign key `_id` attribute, such as `fk_id`. 

In this case the field descriptor would not have been set, and you'd have had the property but not the FK. 

This is no longer possible, the descriptor will be applied. ([https://github.com/django/django/pull/14508/files#diff-8d58c4d1755fbc59fdcb4385fb823cbf8e7a9a76350fd4506590e1878328128dR1211-R1216 See the adjustment to make the test pass here.])

* Can we still though detect that such a configuration error occurred, i.e. that I named a property `*_id` matching an FK accessor? 
* Can we then update the system check (or replace it) and adjust/remove the `test_property_and_related_field_accessor_clash ` test in `tests/invalid_models_tests/test_models.py`? 

Accepting based on [https://github.com/django/django/pull/14508/files#r648437192 the discussion on the PR]"	Cleanup/optimization	new	Database layer (models, ORM)	dev	Normal			Natalia Bidart	Accepted	0	0	0	0	0	0