id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
32625	JSONField with callable default reports ModelForm.has_changed() when it hasn't	Stuart Kelly	nobody	"The issue is similar to this bug that has been fixed: https://code.djangoproject.com/ticket/24428 however isn't due to coercion

test case to reproduce (in a new django project/app)

{{{
from django.db import models
from django.forms import ModelForm


class Vehicle(models.Model):
    modifications = models.JSONField(default=list, blank=True, null=True)


class VehicleForm(ModelForm):
    class Meta:
        model = Vehicle
        fields = (""modifications"", )


def test_vehicle_form():
    vehicle = Vehicle.objects.create()
    assert vehicle.modifications == []
    data = {""modifications"": ""[]""}
    form = VehicleForm(data, instance=vehicle)
    assert form.is_valid()
    assert not form.has_changed()
}}}

I would expect that test to pass, but it doesn't. I'm not sure exactly where the error lies, but I have discovered the following:

{{{
field.show_hidden_initial == True
field.to_python(hidden_widget.value_from_datadict(self.data, self.files, initial_prefixed_name)) == None
}}}
which then fails the check in field.has_changed
{{{
initial_value = initial if initial is not None else ''
data_value = data if data is not None else ''
return initial_value != data_value
}}}
because `data == []`"	Uncategorized	closed	Forms	3.2	Normal	invalid			Unreviewed	0	0	0	0	0	0