id summary reporter owner description type status component version severity resolution keywords cc stage has_patch needs_docs needs_tests needs_better_patch easy ui_ux 32168 Remove serial pk assumptions in aggregation_regress tests Tim Graham Christopher Wang "[https://github.com/cockroachdb/django-cockroachdb CockroachDB] doesn't use serial pks and some tests fail. Feel free to mention me on your pull request if you cannot test your changes on CockroachDB. {{{ ====================================================================== FAIL: test_more_more (aggregation_regress.tests.AggregationTests) ---------------------------------------------------------------------- Traceback (most recent call last): File ""/home/tim/code/django/tests/aggregation_regress/tests.py"", line 702, in test_more_more self.assertSequenceEqual( AssertionError: Sequences differ: != [{'pub': 604193433675366401, 'id__count':[134 chars]: 1}] First differing element 0: {'pub': 604193433639452673, 'id__count': 2} {'pub': 604193433675366401, 'id__count': 2} - + [{'id__count': 2, 'pub': 604193433675366401}, + {'id__count': 1, 'pub': 604193433690800129}, + {'id__count': 2, 'pub': 604193433704824833}, + {'id__count': 1, 'pub': 604193433718816769}] ====================================================================== FAIL: test_more_more_more (aggregation_regress.tests.AggregationTests) ---------------------------------------------------------------------- Traceback (most recent call last): File ""/home/tim/code/django/tests/aggregation_regress/tests.py"", line 880, in test_more_more_more self.assertEqual( AssertionError: Lists differ: [] != ['Apress', 'Sams'] Second list contains 2 additional elements. First extra element 0: 'Apress' - [] + ['Apress', 'Sams'] ====================================================================== FAIL: test_ticket_11293 (aggregation_regress.tests.AggregationTests) ---------------------------------------------------------------------- Traceback (most recent call last): File ""/home/tim/code/django/tests/aggregation_regress/tests.py"", line 1452, in test_ticket_11293 self.assertQuerysetEqual( File ""/home/tim/code/django/django/test/testcases.py"", line 1053, in assertQuerysetEqual return self.assertEqual(list(items), values, msg=msg) AssertionError: Lists differ: [604193433675366401, 604193433718816769, 604193433732775937, 604193433807945729] != [1, 4, 5, 6] First differing element 0: 604193433675366401 1 - [604193433675366401, 604193433718816769, 604193433732775937, 604193433807945729] + [1, 4, 5, 6] }}}" Cleanup/optimization closed Core (Other) dev Normal fixed Ready for checkin 1 0 0 0 1 0