id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
31957	ModelAdmin method save_form not documented but being called multiple times	Ivan Gonzalez	nobody	"I take the opportunity to say this is my first ticket (issue) posted for Django.

As you can search in the docs (https://docs.djangoproject.com/en/dev/ref/contrib/admin/#modeladmin-options). There is no documentation about the `ModelAdmin.save_form` method but is being called multiple times (lines 1763 and 1575 in `django.contrib.admin.options`).

On the other hand, `ModelAdmin.save_form` calls the `form.save` method and `ModelAdmin.save_model` calls the `obj.save` method, but `ModelAdmin.save_form` and `ModelAdmin.save_model` are called in the same flow (lines 1763,1764 and 1575,1580 in `django.contrib.admin.options`), i.e., both can be called in serial leading to multiple saves of the same object. This is specially important when using `signals` because two calls to `obj.save` may trigger duplicate signals when listening to `post_save`, for example. Maybe a better documentation of that, a suggestion of which to use, and if it's possible an optimization of those calls would be great.

I'm all ears to your comments."	Bug	closed	contrib.admin	3.1	Normal	invalid			Unreviewed	0	0	0	0	0	0