id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
31817	sanitize_address() raises TypeError for bytestrings.	Mike Edmunds	nobody	"The code below works in 3.1b1 (and earlier released versions), but results in a TypeError in 3.1rc1:

{{{
$ python manage.py version
3.1rc1
$ python manage.py shell
>>> from django.core.mail.message import sanitize_address
>>> sanitize_address((""Name"".encode('utf-8'), ""to@example.com""), 'utf-8')
Traceback (most recent call last):
  File ""<input>"", line 1, in <module>
    sanitize_address((""Name"".encode('utf-8'), ""to@example.com""), 'utf-8')
  File ""/opt/virtualenvs/python3/lib/python3.8/site-packages/django/core/mail/message.py"", line 99, in sanitize_address
    address_parts = nm + localpart + domain
TypeError: can't concat str to bytes
}}}

Expected behavior:

{{{
$ python manage.py version
3.1b1
$ python manage.py shell
>>> from django.core.mail.message import sanitize_address
>>> sanitize_address((""Name"".encode('utf-8'), ""to@example.com""), 'utf-8')
'=?utf-8?q?Name?= <to@example.com>'
}}}

(Python 3.6, 3.7, 3.8)

This usage comes from the django-anymail package (which I maintain). I realize sanitize_address is not technically a documented Django API, and I'm sure I could find another approach for the particular case this breaks. But I was concerned about it appearing between beta and RC. (FWIW, a quick GitHub search turns up several other apparent uses of sanitize_address in the wild, some with the encoding parameter specified as above.)

Related to the changes for #31784."	Bug	closed	Core (Mail)	3.1	Normal	wontfix		Florian Apolloner	Unreviewed	0	0	0	0	0	0