id,summary,reporter,owner,description,type,status,component,version,severity,resolution,keywords,cc,stage,has_patch,needs_docs,needs_tests,needs_better_patch,easy,ui_ux 31601,postgres_tests.test_search.SearchHeadlineTests fails on latest PostgreSQL versions.,Hannes Ljungberg,Hannes Ljungberg,"A couple of full text search related to headlines tests break on the latest PostgresSQL versions (9.6.18, 10.13 11.8, 12.3). The reason appears to be that a trailing `!` is now present in the results which breaks the equality checks. Looking at the 10.13 release notes ([https://www.postgresql.org/docs/release/10.13/]) it's probable that the patch ""Fix ts_headline() to make better headline selections when working with phrase queries"" introduced this behaviour. Output of failures: {{{ ====================================================================== FAIL [0.015s]: test_headline (postgres_tests.test_search.SearchHeadlineTests) ---------------------------------------------------------------------- Traceback (most recent call last): File ""/tests/django/tests/postgres_tests/test_search.py"", line 569, in test_headline 'Robin. He was not at all afraid to be killed in nasty ' AssertionError: 'R[80 chars]brave, brave, brave Sir Robin!' != 'R[80 chars]brave, brave, brave Sir Robin' - Robin. He was not at all afraid to be killed in nasty ways. Brave, brave, brave, brave Sir Robin! ? - + Robin. He was not at all afraid to be killed in nasty ways. Brave, brave, brave, brave Sir Robin ====================================================================== FAIL [0.019s]: test_headline_separator_options (postgres_tests.test_search.SearchHeadlineTests) ---------------------------------------------------------------------- Traceback (most recent call last): File ""/tests/django/tests/postgres_tests/test_search.py"", line 621, in test_headline_separator_options 'Robin. He was not at all afraid to be killed in ' AssertionError: ', brave Sir Robin!' != ', brave Sir Robin' - Robin. He was not at all afraid to be killed in nasty ways. Brave, brave, brave, brave Sir Robin! ? - + Robin. He was not at all afraid to be killed in nasty ways. Brave, brave, brave, brave Sir Robin ====================================================================== FAIL [0.016s]: test_headline_short_word_option (postgres_tests.test_search.SearchHeadlineTests) ---------------------------------------------------------------------- Traceback (most recent call last): File ""/tests/django/tests/postgres_tests/test_search.py"", line 650, in test_headline_short_word_option ), True) AssertionError: False is not True }}} ",Cleanup/optimization,closed,contrib.postgres,3.1,Normal,fixed,tests,,Accepted,1,0,0,1,0,0