id summary reporter owner description type status component version severity resolution keywords cc stage has_patch needs_docs needs_tests needs_better_patch easy ui_ux 29917 Admin actions are duplicated when using model admins with inheritance Matthias Kestenholz nobody "**Short version:** The introduction of admin.E130 (: (admin.E130) __name__ attributes of actions defined in must be unique.) makes it impossible to define `actions` on a base model admin class. **Longer explanation:** I have an admin base class which defines an `actions` attribute: https://github.com/matthiask/django-cabinet/blob/38d8d4333057d1bb848db0bad88304b05ca3df02/cabinet/base_admin.py#L372 The `actions` attribute isn't overridden in the model admin class which is actually used: https://github.com/matthiask/django-cabinet/blob/38d8d4333057d1bb848db0bad88304b05ca3df02/cabinet/admin.py#L11 So when collecting `actions` from the MRO in ModelAdmin._get_base_actions https://github.com/django/django/blob/5a2dd5ec5330938e9afb77faf6ca89abf39c018c/django/contrib/admin/options.py#L854 the same `move_to_folder` string is added twice which leads to the following failure: https://travis-ci.org/matthiask/django-cabinet/jobs/450169887 The actions dropdown in the administration interface only shows the `move_to_folder` action once (only tested with Django 2.1 and lower), so I'd assume that the uniqueness of actions is enforced later somewhere somehow and the check should probably be reworked to either only check the final result or to take the MRO into account." Bug closed contrib.admin dev Normal fixed Ready for checkin 1 0 0 0 0 0