id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
28578	Rename DatabaseCreation.clone_test_db() argument from number to suffix	Jon Dufresne	nobody	"Recently, I had the need to use `DatabaseCreation.clone_test_db()`. The function has the argument `number`. `number` is [https://github.com/django/django/blob/63d2472b1066c6a2038c5e903aafb5437f78a415/django/db/backends/base/creation.py#L225 concatenated to the end of the database name] to create the test database name. This value does ''not'' need to be a number nor is it used numerically. Any string will do. In my use case, I was using a random string, not a number. Therefore, I find the current name misleading and inaccurate. I suggest the name `suffix` instead.

`DatabaseCreation.clone_test_db()`, `DatabaseCreation._clone_test_db()`, and `DatabaseCreation.get_test_db_clone_settings()` are not documented functions. So I believe no deprecation path is required.

`DatabaseCreation.destroy_test_db()`, which also has the `number` argument, [https://docs.djangoproject.com/en/1.11/topics/testing/advanced/#django.db.connection.creation.destroy_test_db is documented], but the `number` argument is not part of that documentation. I'm not sure if this is intentional or an oversight. But if intentional, again, I believe no deprecation path is required.

If I'm misunderstanding and a deprecation path is required, please let me know."	Cleanup/optimization	closed	Database layer (models, ORM)	dev	Normal	fixed			Accepted	1	0	0	0	0	0