id summary reporter owner description type status component version severity resolution keywords cc stage has_patch needs_docs needs_tests needs_better_patch easy ui_ux 28454 Simplify use of Query.setup_joins() by returning a named tuple Matthew Wilkes matthewwilkes "This is split from review of #24747's PR, specifically https://github.com/django/django/pull/8528#discussion-diff-127578267R1463 > @jarshwah > This is getting out of hand, especially considering callers ignoring so many of the return values. Does it make sense to create a type to model these values? At a minimum I think we should consider namedtuple. > @MatthewWilkes > No argument here, I got a bit of underscore blindness at times. Think that should be its own PR, so we don't have too much refactoring in with functionality changes? > @timgraham > Yes please The `Query.setup_joins()` method currently returns a tuple of many pieces of data. #24747 adds another to that list. As many users of `setup_joins()` unpacked multiple variables to `_` placeholders, it was decided to simplify usage and make it easier to add additional items to the tuple without changing the unpacking." Cleanup/optimization closed Database layer (models, ORM) dev Normal fixed orm Accepted 0 0 0 0 0 0