Opened 7 years ago

Closed 4 years ago

#28290 closed Cleanup/optimization (fixed)

Doc sections are missing target (labels) links

Reported by: Tony Narlock Owned by: Abhijeet Viswa
Component: Documentation Version: 1.11
Severity: Normal Keywords: docs labels intersphinx
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Experiencing this while writing an article about Django. Some sections are missing intersphinx references.

This has actually been plaguing me for a few years when trying to link up Django's excellent docs via sphinx. Probably 85% of intersphinx links to Django work perfectly, but there are some outliers.

With sphinx installed (pip install --user sphinx), this command can be used to print intersphinx reference names to stdout (for double checking).

python -m sphinx.ext.intersphinx 'http://docs.djangoproject.com/en/1.11/_objects/'

Supposedly, docutils/sphinx is supposed to automatically assign target links:

Labels that aren’t placed before a section title can still be referenced to, but you must give the link an explicit title, using this syntax: :ref:Link title <label-name>.

source: http://www.sphinx-doc.org/en/stable/markup/inline.html#role-ref

For reference, I also opened a possibly related Sphinx-doc ticket about that: https://github.com/sphinx-doc/sphinx/issues/3856

Here are a few cases of missing sections that need manual labels:

Using Sessions in views (git, docs)

Shell (git docs)

Change History (10)

comment:1 by Tony Narlock, 7 years ago

Owner: changed from nobody to Tony Narlock
Status: newassigned

Here is another one I can't get a header for.

https://docs.djangoproject.com/en/1.11/topics/http/views/#a-simple-view

https://github.com/django/django/blob/424187e/docs/topics/http/views.txt#L15

To add, using sphinx 1.6.3, python 3.6.1, macOS siera.

Version 0, edited 7 years ago by Tony Narlock (next)

comment:2 by Tim Graham, 7 years ago

Triage Stage: UnreviewedAccepted

comment:5 by Carlton Gibson, 5 years ago

Owner: Tony Narlock removed
Status: assignednew

Hi Tony, I'm going to deassign this. It's been 20months without a patch, and as an Easy Pickings ticket it's likely to get picked up quickly if not claimed. Please do reclaim if you do in fact have a patch. Thanks for the report!

comment:6 by Kamalesh Palanisamy, 5 years ago

Owner: set to Kamalesh Palanisamy
Status: newassigned

comment:7 by Kees Hink, 5 years ago

Owner: changed from Kamalesh Palanisamy to Kees Hink

To make sure i understand the issue correctly: Anchors seem to be working fine, see https://docs.djangoproject.com/en/1.11/topics/http/sessions/#django.contrib.sessions.backends.base.SessionBase.__getitem as an example.

What seems to be missing is the link to the source code. There's a working example of such a [source] link in https://docs.djangoproject.com/en/2.2/howto/custom-management-commands/#django.core.management.BaseCommand. That link takes you to https://docs.djangoproject.com/en/2.2/_modules/django/core/management/base/#BaseCommand.

I think this is also the intended behavior for the reported pages, because there's a class directive. Is that correct?

Last edited 5 years ago by Kees Hink (previous) (diff)

comment:8 by Tapasweni Pathak, 5 years ago

Hello folks: Can I take the ticket?

comment:9 by Abhijeet Viswa, 4 years ago

Has patch: set
Owner: changed from Kees Hink to Abhijeet Viswa

comment:10 by GitHub <noreply@…>, 4 years ago

Resolution: fixed
Status: assignedclosed

In 1a9459b:

Fixed #28290 -- Enabled Sphinx auto-label generation for title and section headers.

Note: See TracTickets for help on using tickets.
Back to Top