id summary reporter owner description type status component version severity resolution keywords cc stage has_patch needs_docs needs_tests needs_better_patch easy ui_ux 27921 Documentation of make_aware() with is_dst is misleading Kevin Christopher Henry Glenn Paquette "A recent [http://stackoverflow.com/questions/42399438/django-make-aware-usage/42407744 StackOverflow question] prompted me to look into what `make_aware()` does with non-existent datetimes. The [https://docs.djangoproject.com/en/dev/ref/utils/#django.utils.timezone.make_aware documentation] says: > Setting `is_dst` to `True` or `False` will avoid the exception by moving the hour backwards or forwards by 1 respectively. For example, `is_dst=True` would change a nonexistent time of 2:30 to 1:30 and `is_dst=False` would change the time to 3:30. It appears that pytz in fact keeps the wall-clock time of 2:30 the same, and instead shifts the timezone to make the datetime valid. I'm not sure if it's better to describe what pytz does more precisely, or just to leave out that degree of detail (since pytz's documentation is itself not very precise on this point)." Bug closed Documentation dev Normal fixed Josh Smeaton Accepted 1 0 0 0 0 0