id summary reporter owner description type status component version severity resolution keywords cc stage has_patch needs_docs needs_tests needs_better_patch easy ui_ux 27821 Documentation of the return value of clean_() could be clarified Christian Ullrich nobody "The documentation on form validation (/ref/forms/validation/) has this to say regarding the clean_ method on a Form subclass: This method should return the cleaned value obtained from cleaned_data, regardless of whether it changed anything or not. This is incorrect; the method should return the value to be used for further processing, because its result is unconditionally put ''into'' cleaned_data: (from django.forms.forms.Form._clean_fields():) {{{ if hasattr(self, 'clean_%s' % name): value = getattr(self, 'clean_%s' % name)() self.cleaned_data[name] = value }}} " Cleanup/optimization closed Documentation 1.10 Normal fixed Accepted 1 0 0 0 0 0