id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
27510	Allow custom keyword arguments to modelform_factory in ModelFormMixin	Tom Forbes	nobody	"Hello,
I think that only being able to pass the `fields` keyword argument in `ModelFormMixin.get_form_class()` is very limiting. 

Being able to specify the fields greatly reduces boilerplate and is an awesome feature, but the moment you want anything more then you have to create a ModelForm. Tim Graham argues in #24589 that ""I don't think the possibility of saving a few lines of user code justifies the complexity of reimplementing the parameters to `modelform_factory()` as CBV parameters and methods."", however I don't believe that it adds any significant complexity and sorely missing in some circumstances, and it already exists for standard forms via the `get_form_kwargs()` functionality.

The main use case for this feature would be adding custom widgets to model forms. For example, if you have a view that can return two different sets of fields based on the viewing user and you require one of them to have a custom widget for this field then you would have to define two separate model forms, one with each set of fields. If you then want to add another set of fields for a user type then you need yet another model form. This gets tiring very fast.

What is wrong with simply having a `get_modelform_kwargs()` method that by default returns `{""fields"": self.fields}`? The implementation would be very short.

I'm willing to work on a patch if others agree this is a good idea."	New feature	new	Generic views	1.10	Normal				Unreviewed	0	0	0	0	0	0