Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#27318 closed Cleanup/optimization (fixed)

Return failed values from memcached.set_many()

Reported by: Florent Fourcot Owned by: Olivier Tabone
Component: Core (Cache system) Version: 1.10
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The set_many method of MemcachedBackend does not return anything, even if both python-memcached and pylibmc libraries return the list of failing keys.

As result, the backend can fail silently.

Attachments (1)

0001-Fixed-27318-Return-list-of-failing-keys-with-set_man.patch (1.2 KB ) - added by Florent Fourcot 7 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 by Tim Graham, 7 years ago

Needs tests: set
Summary: No return of failed values with memcached.set_many()Return failed values from memcached.set_many()
Triage Stage: UnreviewedAccepted
Type: BugCleanup/optimization

As noted on the PR, tests are needed.

comment:2 by Olivier Tabone, 7 years ago

Owner: changed from nobody to Olivier Tabone
Status: newassigned

claim the ticket, created a new PR (the other one was just a one liner).

please review the pr.

Added tests, as recommended in the original PR review.
updated the docs

Version 0, edited 7 years ago by Olivier Tabone (next)

comment:3 by Tim Graham, 7 years ago

Needs tests: unset
Patch needs improvement: set

I left comments for improvement on the PR.

comment:4 by Olivier Tabone, 7 years ago

Patch needs improvement: unset

updated the PR, please feel free to review and comment.

comment:5 by Olivier Tabone, 7 years ago

updated the PR
rebase from master

comment:6 by Tim Graham, 7 years ago

Patch needs improvement: set

comment:7 by Tim Graham, 7 years ago

Patch needs improvement: unset

comment:8 by Tim Graham <timograham@…>, 7 years ago

Resolution: fixed
Status: assignedclosed

In a027447:

Fixed #27318 -- Made cache.set_many() return the list of failed keys.

comment:9 by Tim Graham <timograham@…>, 6 years ago

In abacd09:

Refs #27318 -- Made DummyCache.set_many() return a list for consistency with other backends.

comment:10 by Tim Graham <timograham@…>, 6 years ago

In ea901eb:

[2.0.x] Refs #27318 -- Made DummyCache.set_many() return a list for consistency with other backends.

Backport of abacd09f07f4bb0aa1a3a32bc6e3c3570fa76912 from master

Note: See TracTickets for help on using tickets.
Back to Top