Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#24161 closed Bug (fixed)

Using UUIDField for id of custom User model prevents logging in

Reported by: James Beith Owned by: nobody
Component: contrib.sessions Version: 1.8alpha1
Severity: Release blocker Keywords:
Cc: Simon Charette Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

When using the new UUIDField in Django 1.8 for the id of a custom User model, a session fails to be created and a TypeError exception is thrown when attempting to log in.

TypeError at /login/
UUID('314cb5d6-593f-48f5-b1af-fadedde123d3') is not JSON serializable

Please see the README.md file of the attached example project.

Attachments (1)

619295fe.zip​ (8.7 KB ) - added by James Beith 9 years ago.
Example project

Download all attachments as: .zip

Change History (9)

by James Beith, 9 years ago

Attachment: 619295fe.zip​ added

Example project

comment:1 by Simon Charette, 9 years ago

Thanks for the example project. Could you also provide the full traceback please.

comment:2 by Simon Charette, 9 years ago

Triage Stage: Unreviewed → Accepted

I guess we should use user.serializable_value(user._meta.pk.attname) ​here.

in reply to:  1 comment:3 by James Beith, 9 years ago

Replying to charettes:

Thanks for the example project. Could you also provide the full traceback please.

​http://dpaste.com/3JNZ2YR

Version 1, edited 9 years ago by James Beith (previous) (next) (diff)

comment:4 by Simon Charette, 9 years ago

Has patch: set

Create a ​PR but I'm not sure get_prep_value is the correct solution here.

Maybe we should document that your session serializer should be able to deal with your user primary key type?

I guess we could also rely on the check framework to make sure it's the case.

comment:5 by Simon Charette, 9 years ago

Cc: Simon Charette added

comment:6 by Simon Charette, 9 years ago

Triage Stage: Accepted → Ready for checkin

Tim's patch LGTM.

comment:7 by Tim Graham <timograham@…>, 9 years ago

Resolution: → fixed
Status: new → closed

In 0f7f5bc9e7a94ab91c2b3db29ef7cf000eff593f:

Fixed #24161 -- Stored the user primary key as a serialized value in the session.

This allows using a UUIDField primary key along with the JSON session
serializer.

Thanks to Trac alias jamesbeith for the report and Simon Charette
for the initial patch.

comment:8 by Tim Graham <timograham@…>, 9 years ago

In 596564e808089f1263469dbf4744dcaa05b79222:

[1.8.x] Fixed #24161 -- Stored the user primary key as a serialized value in the session.

This allows using a UUIDField primary key along with the JSON session
serializer.

Thanks to Trac alias jamesbeith for the report and Simon Charette
for the initial patch.

Backport of 0f7f5bc9e7a94ab91c2b3db29ef7cf000eff593f from master

Note: See TracTickets for help on using tickets.
Back to Top