﻿id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
23085	AlterField/RenameField doesn't work on GIS fields on PostGIS 1.5	jgoclawski	Andrew Godwin	"Steps to reproduce:

0. Have PostGIS version 1.5, GeoDjango properly configured, etc., Django version 1.7b3
1. Create a simple model:

{{{
from django.contrib.gis.db import models


class Example(models.Model):
    coordinates = models.PointField(blank=True, null=True, srid=4326)


}}}
2. Create initial migrations
3. Change model to:

{{{

from django.contrib.gis.db import models


class Example(models.Model):
    coordinates = models.PointField(blank=True, null=True, srid=4326, db_column='coordinates')


}}}
4. Generate an automatic migration, which will look something like this:


{{{
# encoding: utf8
from __future__ import unicode_literals

from django.db import models, migrations
import django.contrib.gis.db.models.fields


class Migration(migrations.Migration):

    # dependencies

    operations = [
        migrations.AlterField(
            model_name='example',
            name='coordinates',
            field=django.contrib.gis.db.models.fields.PointField(db_column='coordinates', srid=4326, blank=True, null=True),
        ),
    ]
}}}
5. Run migrate


Result:


{{{
Traceback (most recent call last):
  File ""/[... truncated ...]/lib/python3.3/site-packages/coverage/execfile.py"", line 104, in run_python_file
    exec_code_object(code, main_mod.__dict__)
  File ""/[... truncated ...]/lib/python3.3/site-packages/coverage/backward.py"", line 93, in exec_code_object
    exec(code, global_map)
  File ""/[... truncated ...]/bin/django-admin.py"", line 5, in <module>
    management.execute_from_command_line()
  File ""/[... truncated ...]/lib/python3.3/site-packages/django/core/management/__init__.py"", line 427, in execute_from_command_line
    utility.execute()
  File ""/[... truncated ...]/lib/python3.3/site-packages/django/core/management/__init__.py"", line 419, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File ""/[... truncated ...]/lib/python3.3/site-packages/django/core/management/base.py"", line 288, in run_from_argv
    self.execute(*args, **options.__dict__)
  File ""/[... truncated ...]/lib/python3.3/site-packages/django/core/management/base.py"", line 337, in execute
    output = self.handle(*args, **options)
  File ""/[... truncated ...]/lib/python3.3/site-packages/django_jenkins/management/commands/__init__.py"", line 89, in handle
    if test_runner.run_tests(test_labels):
  File ""/[... truncated ...]/lib/python3.3/site-packages/django/test/runner.py"", line 147, in run_tests
    old_config = self.setup_databases()
  File ""/[... truncated ...]/lib/python3.3/site-packages/django_jenkins/runner.py"", line 161, in setup_databases
    return super(CITestSuiteRunner, self).setup_databases()
  File ""/[... truncated ...]/lib/python3.3/site-packages/django/test/runner.py"", line 109, in setup_databases
    return setup_databases(self.verbosity, self.interactive, **kwargs)
  File ""/[... truncated ...]/lib/python3.3/site-packages/django/test/runner.py"", line 297, in setup_databases
    verbosity, autoclobber=not interactive)
  File ""/[... truncated ...]/lib/python3.3/site-packages/django/db/backends/creation.py"", line 368, in create_test_db
    test_database=True)
  File ""/[... truncated ...]/lib/python3.3/site-packages/django/core/management/__init__.py"", line 167, in call_command
    return klass.execute(*args, **defaults)
  File ""/[... truncated ...]/lib/python3.3/site-packages/django/core/management/base.py"", line 337, in execute
    output = self.handle(*args, **options)
  File ""/[... truncated ...]/lib/python3.3/site-packages/django/core/management/commands/migrate.py"", line 146, in handle
    executor.migrate(targets, plan, fake=options.get(""fake"", False))
  File ""/[... truncated ...]/lib/python3.3/site-packages/django/db/migrations/executor.py"", line 62, in migrate
    self.apply_migration(migration, fake=fake)
  File ""/[... truncated ...]/lib/python3.3/site-packages/django/db/migrations/executor.py"", line 96, in apply_migration
    migration.apply(project_state, schema_editor)
  File ""/[... truncated ...]/lib/python3.3/site-packages/django/db/migrations/migration.py"", line 107, in apply
    operation.database_forwards(self.app_label, schema_editor, project_state, new_state)
  File ""/[... truncated ...]/lib/python3.3/site-packages/django/db/migrations/operations/fields.py"", line 132, in database_forwards
    schema_editor.alter_field(from_model, from_field, to_field)
  File ""/[... truncated ...]/lib/python3.3/site-packages/django/db/backends/schema.py"", line 484, in alter_field
    if old_type is None and new_type is None and (old_field.rel.through and new_field.rel.through and old_field.rel.through._meta.auto_created and new_field.rel.through._meta.auto_created):
AttributeError: 'NoneType' object has no attribute 'through'

}}}

Reason (my guess):
django.contrib.gis.db.models.fields.GeometryField.db_type (used by alter_field as old_field.db_parameters):

{{{
def db_type(self, connection):
        return connection.ops.geo_db_type(self)
}}}
 

django.contrib.gis.db.backends.postgis.operations.geo_db_type returns None for PostGIS 1.5, which causes above exception"	Bug	closed	Migrations	1.7-rc-1	Release blocker	fixed			Accepted	0	0	0	0	0	0
