Fix camelCase test names

[Tim Graham]

In some test files like tests/admin_widgets/tests.py, there are tests with names like testDateField where it should be test_date_field. Note that it's fine for assertions to be camel cased, so there's no need to change things like assertFormfield. I have seen this most often in the admin_* tests, so those would be the main ones to check.

[brylie]

​DONE -- The admin_custom_urls package has camel case tests.

[brylie]

SKIPPED -- admin_filters may need consistent spacing in test functions in the ListFiltersTests class. Please review and comment as to whether spacing/underscores should be changed.

[brylie]

admin_views has several camel case test names.

[brylie]

​DONE -- admin_widgets needs cleanup.

[brylie]

​DONE -- bug639 has one camel case test name.

Q: Should this test be moved into another, more general, test module (likewise with "bug8245" test module)?

[brylie]

​DONE -- conditional_processing needs cleanup.

[brylie]

​DONE -- dispatch has camel case test names.

Also, the tests were created in a sub-directory: dispatch/tests/test_dispatcher.py

Q: Should the tests be moved up to the dispatch directory, and possibly renamed tests.py?

[brylie]

IGNORE -- file_uploads has set up and tear down classes that are named setUpClass and tearDownClass. Should these be renamed to setUp and tearDown?

[brylie]

IGNORE -- fixtures has two test functions named testClassFixtures. Should these be renamed?

[brylie]

IGNORE -- fixtures_model_package has one function named testClassFixtures. Should this be renamed?

[brylie]

​DONE -- generic_inline_admin has camel case test names.

[brylie]

​DONE -- model_fields contains a function without a camel case for the field name: test_slugfield_max_length

This is inconsistent with other field names in test functions. Should this be changed to test_SlugField_max_length?

There are several similar functions in class ValidationTest. Should field names in these functions be changed to camel case?

[brylie]

​DONE -- nested_foreign_keys has camel case test names.

[brylie]

​DONE -- raw_query has camel case test names.

[brylie]

​DONE -- utils_tests/test_http has camel case test names.

[brylie]

​DONE -- view_tests/tests/test_i18n has camel case test names.

[Tim Graham]

Thanks for looking at this. Let's just focus on camel case test names for this ticket. We can open a separate one for some of the other issues you raised.

To address some specific questions:

• admin_filters -- think it's fine to leave as-is.
• bug* -- yes, let's move them, but as a separate item.
• dispatch -- probably move them as a separate item.
• file_uploads -- setUpClass/tearDownClass are fine.
• model_fields -- I'd remove the existing camel case for field names.

[brylie]

Replying to brylie:

The admin_custom_urls package has camel case tests.

Fixed.

[brylie]

Replying to timo:

• model_fields -- I'd remove the existing camel case for field names.

Ah, dang. I just went with the opposite and ​added camel case to field names in tests. I think this is a good strategy for three reasons:

1. It is consistent with other tests/test suites
2. It is consistent with the Django API
3. It improves readability, which seems to be a priority here

Does this seem reasonable?

[brylie]

OK, I have modified the files where I found camel case test names. If you will, please review the following changes.

• ​admin_custom_urls/tests.py
• ​admin_views/tests.py
• ​admin_widgets/tests.py
• ​conditional_processing/tests.py
• ​dispatch/tests/test_dispatcher.py
• ​generic_inline_admin/tests.py
• ​model_fields/tests.py
• ​nested_foreign_keys/tests.py
• ​raw_query/tests.py
• ​utils_tests/test_http.py
• ​view_tests/tests/i18n/tests.py

[brylie]

Patch containing changes for test names in several test suites.

[Tim Graham <timograham@…>]

In 89b9e6e5d68297e7fe10baea6abcd96e24de0e09:

Fixed #22909 -- Removed camelCasing in some tests.

Thanks brylie.

[Tim Graham <timograham@…>]

In 28962c57f3f2b4543cd67d55ca635e9198f585dd:

[1.7.x] Fixed #22909 -- Removed camelCasing in some tests.

Thanks brylie.

Backport of 89b9e6e5d6 from master

[Tim Graham]

I moved the dispatch tests in 136a3ffe21988d49e443867d129cc01fb62b34cd and created #22979 for moving the bug tests.