#22602 closed Cleanup/optimization (fixed)
Complete test coverage for makemigrations command
| Reported by: | Claude Paroz | Owned by: | Huu Nguyen |
|---|---|---|---|
| Component: | Migrations | Version: | 1.7-beta-2 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | yes | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Currently the coverage report of the makemigrations management command is only 61%. Let's try our best to extend this to 100% before releasing it.
http://ci.djangoproject.com/job/Django%20Coverage/HTML_Coverage_Report/_var_lib_jenkins_jobs_Django%20Coverage_workspace_django_core_management_commands_makemigrations.html
Not blocking for the RC.
Change History (7)
comment:2 by , 10 years ago
| Severity: | Release blocker → Normal |
|---|
100% coverage is rarely achievable (nor useful) for management commands. However, 41% is a bit low ;-)
comment:3 by , 10 years ago
| Needs tests: | set |
|---|
comment:4 by , 10 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:5 by , 10 years ago
| Has patch: | set |
|---|
Opened up a pull request for this here. Improved code coverage from 61% to 98%.
comment:6 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
I question this being marked as a release blocker at all; while I love test coverage as much as the next person, it doesn't find all the bugs, and trying to attain 100% coverage on a command that's very difficult to test because of the fact that it does filesystem operations is just going to slow us down.
Unless there's a convincing argument otherwise, I'd like to demote this from release blocker back down to normal.