id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
22105	Model error messages overwritten by modelform django defaults	daniel@…	Dr_White	"Imagine a model with custom error messages added to some of it's fields.

{{{
from django.db import models


class MyModel(models.Model):
    name = models.CharField(
        max_length=255,
        error_messages={
            'required': 'my required msg..',
        }
    )
}}}

When a modelform is created from this model

{{{
from django.forms import ModelForm
from .models import MyModel


class MyModelForm(ModelForm):

    class Meta:
        model = MyModel
        fields = ['name']
}}}

I would expect to see the custom error message.
Instead the function _update_errors from BaseModelForm simply doesn't care, I quote:
    '''Override any validation error messages defined at the model level with those defined at the form level.'''

I believe any custom error message defined in the model should take precedence over the default form messages.
Whenever error messages also defined in the modelform meta like so:


{{{
class MyModelForm(ModelForm):

    class Meta:
        model = MyModel
        fields = ['name']
        error_messages = {
            'name': {
                'required': ""This is a custom error message from modelform meta"",
            },
        }
}}}

Then the error message from the modelform should be used."	Bug	closed	Forms	dev	Normal	invalid	error_messages, model, error, form,  _update_errors		Unreviewed	0	0	0	0	0	0