id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
2142	[patch] Firefox JavaScript Console reports two warnings for admin script	mike.capp@…	Adrian Holovaty	"'''""function removeEvent does not always return a value"" at contrib/admin/media/js/core.js line 25'''

[http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/detachevent.asp MSDN docs] state that detachEvent has no return, so we should presumably return true as we do for the removeEventListener path.

Incidentally (and somewhat offtopic) the addEvent in contrib/admin/media/js/admin/ordering.js appears to be an unnecessary duplicate of the one in core.js - the additional useCapture arg in this version isn't used by the only call to it.

'''variable e hides argument at contrib/admin/media/js/admin/DateTimeShortcuts.js line 220'''

The 'var' isn't necessary here; assigning to an undefined arg doesn't affect any variables with the same name in enclosing scopes. That is,

{{{
var e = 123;
function foo(e) { if (!e) e = 456; alert(""in foo e is "" + e); }
foo();
alert(""outside foo e is "" + e);
}}}

alerts 456 then 123. (Checked in FF, IE and Opera.)"	defect	closed	contrib.admin		minor	fixed			Unreviewed	1	0	0	0	0	0