id summary reporter owner description type status component version severity resolution keywords cc stage has_patch needs_docs needs_tests needs_better_patch easy ui_ux 21256 Error in django.utils.datetime_safe.datetime.combine method Łukasz nobody "There seems to be an error in the `combine()` method of the `django.utils.datetime_safe.datetime` class. Current definition: {{{ def combine(self, date, time): return datetime(date.year, date.month, date.day, time.hour, time.minute, time.microsecond, time.tzinfo) }}} The `time.second` value is not passed to the `datetime` constructor. Moreover, this method should be a ''classmethod'', like so: {{{ @classmethod def combine(cls, date, time): return cls(date.year, date.month, date.day, time.hour, time.minute, time.second, time.microsecond, time.tzinfo) }}} " Bug closed Utilities 1.5 Release blocker fixed Accepted 0 0 0 0 0 0