id,summary,reporter,owner,description,type,status,component,version,severity,resolution,keywords,cc,stage,has_patch,needs_docs,needs_tests,needs_better_patch,easy,ui_ux 21112,Sitemaps without lastmod dates are broken (Django 1.7 / master only),Matthias Kestenholz,nobody,"While running the FeinCMS testsuite with Django 1.7 / master, I found a new problem introduced by 8f5533ab250df07ea84f98d39808806e282468a5 (the fix for #20793). {{{ Traceback (most recent call last): File ""/home/mk/Projects/feincms/tests/testapp/tests/test_page.py"", line 1428, in test_36_sitemaps response = self.client.get('/sitemap.xml') File ""/home/mk/Projects/feincms/tests/.tox/py27-1.7.X/src/django/django/test/client.py"", line 452, in get response = super(Client, self).get(path, data=data, **extra) File ""/home/mk/Projects/feincms/tests/.tox/py27-1.7.X/src/django/django/test/client.py"", line 279, in get return self.generic('GET', path, **r) File ""/home/mk/Projects/feincms/tests/.tox/py27-1.7.X/src/django/django/test/client.py"", line 341, in generic return self.request(**r) File ""/home/mk/Projects/feincms/tests/.tox/py27-1.7.X/src/django/django/test/client.py"", line 423, in request six.reraise(*exc_info) File ""/home/mk/Projects/feincms/tests/.tox/py27-1.7.X/src/django/django/core/handlers/base.py"", line 114, in get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File ""/home/mk/Projects/feincms/tests/.tox/py27-1.7.X/src/django/django/contrib/sitemaps/views.py"", line 15, in inner response = func(request, *args, **kwargs) File ""/home/mk/Projects/feincms/tests/.tox/py27-1.7.X/src/django/django/contrib/sitemaps/views.py"", line 75, in sitemap timegm(site.latest_lastmod.utctimetuple())) AttributeError: 'NoneType' object has no attribute 'utctimetuple' }}} The attached patch ensures that site.latest_lastmod is only set if it actually is a datetime value. Test is included. (PS: This is my 21. issue submitted to the Django bugtracker; I did not count patches but I would be a honor if someone could add me to the AUTHORS file. https://code.djangoproject.com/query?owner=mk / https://code.djangoproject.com/query?reporter=mk TIA :-)",Bug,closed,contrib.sitemaps,dev,Normal,fixed,,,Accepted,1,0,0,1,0,0