id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
20996	formset factories override any supplied formset max_num	Keryn Knight <django@…>	nobody	"Because of the way `formset_factory` yields a new object based on a given `formset` argument, during which it manually sets some attrs on the resulting object, it is impossible for the following to work:
{{{
class MyFormset(BaseFormSet):
    def _max_num(self):
        return 9000 # or whatever
    max_num = property(_max_num)

FromFactory = formset_factory(MyForm, formset=MyFormset)
FromFactory.max_num # will be 1000
FromFactory.max_num = FromFactory._max_num()
FromFactory.max_num # will be 9000
}}}
It seems inconsiderate for the factory to override the max_num regardless of what the FormSet says is ok, silently.

I've left it uncategorized, because I can see the argument for the way it behaves currently [especially WRT backwards compatibility], but if it's not fixed, it may be worth finding a place in the documentation [docstrings and/or real docs] to indicate the behaviour."	Uncategorized	closed	Forms	dev	Normal	invalid			Unreviewed	0	0	0	0	0	0