﻿id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
19846	Simplify BlockContext code with defaultdict	FunkyBob	nobody	"Just a tiny cleanup that likely gives better performance... replace the manual work with a defaultdict(list):

{{{
diff --git a/django/template/loader_tags.py b/django/template/loader_tags.py
index d295d05..6dbe49f 100644
--- a/django/template/loader_tags.py
+++ b/django/template/loader_tags.py
@@ -5,6 +5,8 @@ from django.template.loader import get_template
 from django.utils.safestring import mark_safe
 from django.utils import six
 
+from collections import defaultdict
+
 register = Library()
 
 BLOCK_CONTEXT_KEY = 'block_context'
@@ -15,19 +17,16 @@ class ExtendsError(Exception):
 class BlockContext(object):
     def __init__(self):
         # Dictionary of FIFO queues.
-        self.blocks = {}
+        self.blocks = defaultdict(list)
 
     def add_blocks(self, blocks):
         for name, block in six.iteritems(blocks):
-            if name in self.blocks:
-                self.blocks[name].insert(0, block)
-            else:
-                self.blocks[name] = [block]
+            self.blocks[name].insert(0, block)
 
     def pop(self, name):
         try:
             return self.blocks[name].pop()
-        except (IndexError, KeyError):
+        except IndexError:
             return None
 
     def push(self, name, block):
@@ -36,7 +35,7 @@ class BlockContext(object):
     def get_block(self, name):
         try:
             return self.blocks[name][-1]
-        except (IndexError, KeyError):
+        except IndexError:
             return None
 
 class BlockNode(Node):
}}}
"	Cleanup/optimization	closed	Template system	1.4	Normal	fixed			Accepted	1	0	0	0	1	0
