id summary reporter owner description type status component version severity resolution keywords cc stage has_patch needs_docs needs_tests needs_better_patch easy ui_ux 19779 Regression in redirects middleware Aymeric Augustin nobody "After upgrading docs.djangoproject.com to 1.5 rc 1 static files fail to load. {{{ Environment: Request Method: GET Request URL: http://localhost:8000/s/css/base.css/ Django Version: 1.5c1 Python Version: 2.7.2 Installed Applications: ['docs', 'haystack'] Installed Middleware: ['djangosecure.middleware.SecurityMiddleware', 'django.middleware.clickjacking.XFrameOptionsMiddleware', 'django.contrib.sessions.middleware.SessionMiddleware', 'django.contrib.messages.middleware.MessageMiddleware', 'django.middleware.csrf.CsrfViewMiddleware', 'django.contrib.auth.middleware.AuthenticationMiddleware', 'django.middleware.common.CommonMiddleware', 'django.contrib.flatpages.middleware.FlatpageFallbackMiddleware', 'django.contrib.redirects.middleware.RedirectFallbackMiddleware'] Traceback: File ""/Users/myk/.virtualenvs/dp.com/lib/python2.7/site-packages/django/core/handlers/base.py"" in get_response 187. response = middleware_method(request, response) File ""/Users/myk/.virtualenvs/dp.com/lib/python2.7/site-packages/django/contrib/redirects/middleware.py"" in process_response 13. r = Redirect.objects.get(site__id__exact=current_site.id, old_path=path) Exception Type: AttributeError at /s/css/base.css/ Exception Value: 'RequestSite' object has no attribute 'id' }}} This regression was introduced in 6c2faaceb0482267cec19da0ff432984028f9d0c. I'm not sure it's a good idea to use `get_current_site()`, which can return a `RequestSite`, in code that obviously needs a `Site`. Possible solutions: - rollback the change in the redirect middleware - give `RequestSite` `pk` and `id` attributes returning `settings.SITE_ID`" Bug closed contrib.redirects 1.5-rc-1 Release blocker fixed Ready for checkin 1 0 0 0 0 0