id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
19190	Refactor sql.query.select and select_fields	Anssi Kääriäinen	nobody	"I introduced some major gis regressions in commit [f64a5ef404cb6fd28e008a01039a3beea2fa8e1b] - a fix for #19102. The reason for the regressions was that Query.select and select_fields must be in sync, but this applies only to gis backend. The commit did:
{{{
qs.select = [something]
}}}
while it should have done:
{{{
qs.select, qs.select_fields = [something], [None]
}}}

The qs.select and select_fields must always be edited in sync for gis to work. There are not even comments explaining how select and select_fields work currently.

I have implemented [https://github.com/akaariai/django/compare/rm_select_fields a refactor for this] which removes select_fields and collapses it into qs.select. This way it will be impossible to do the same mistake I did in future.

It seems similar refactoring should be done for related_select_cols/related_select_fields."	Cleanup/optimization	closed	Database layer (models, ORM)	dev	Normal	fixed			Ready for checkin	1	0	0	0	0	0