id summary reporter owner description type status component version severity resolution keywords cc stage has_patch needs_docs needs_tests needs_better_patch easy ui_ux 19187 qs.values().delete() doesn't work consistently Anssi Kääriäinen nobody "If you do SomeModel.objects.values().delete() you will get a stack trace like this one: {{{ File ""/home/akaariai/Programming/django/tests/django/db/models/query.py"", line 525, in delete collector.collect(del_query) File ""/home/akaariai/Programming/django/tests/django/db/models/deletion.py"", line 195, in collect reverse_dependency=reverse_dependency) File ""/home/akaariai/Programming/django/tests/django/db/models/deletion.py"", line 105, in add if obj not in instances: TypeError: unhashable type: 'dict' }}} However if the ""fast-path"" deletion route is taken, then the deletion will work. I think we should make values().delete() and values_list().delete() throw an error explicitly. We might later on want to make values().delete() work, or have special meaning for such queries (see #9519 for example). But for now making sure that this errors consistently seems like a good idea." Bug closed Database layer (models, ORM) 1.4 Normal fixed Ready for checkin 1 0 0 0 0 0