id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
19145	valid formset with invalid deleted form raises AttributeError when trying to access cleaned_data	valtron2000@…	nobody	"Example (run in `manage.py shell`):

{{{
from django.forms import Form, BooleanField
from django.forms.formsets import formset_factory

class F(Form):
	a = BooleanField()

FS = formset_factory(form = F, can_delete = True)

fs = FS(data = {
	'form-MAX_NUM_FORMS': '',
	'form-INITIAL_FORMS': '1',
	'form-TOTAL_FORMS': '1',
	'form-0-a': '',
	'form-0-DELETE': 'on',
})

assert fs.is_valid()

# fs.forms[0].cleaned_data raises AttributeError
print fs.cleaned_data
}}}

This can be fixed by changing `BaseFormSet._get_cleaned_data` to only return the `cleaned_data` of non-deleted forms:

{{{
def _get_cleaned_data(self):
    """"""
    Returns a list of form.cleaned_data dicts for every form in self.forms.
    """"""
    if not self.is_valid():
        raise AttributeError(""'%s' object has no attribute 'cleaned_data'"" % self.__class__.__name__)
    return [form.cleaned_data for form in self.forms if not self._should_delete_form(form)]
}}}"	Bug	closed	Forms	1.4	Normal	duplicate	formset cleaned_data		Unreviewed	0	0	0	0	0	0