Opened 4 years ago

Closed 4 years ago

#18775 closed Bug (invalid)

ROPhoneNumberField does not support several Romanian phone number formats

Reported by: Daniel Ursache-Dogariu Owned by: Daniel Ursache-Dogariu
Component: contrib.localflavor Version: master
Severity: Normal Keywords: romanian, phone, field, localflavorsplit
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The ROPhoneNumberField form field only supports 10 digit phone numbers. It does not accept valid formats like the short national phone numbers (3 or 6 digits), or geographic short numbers (7 digits).

Change History (4)

comment:1 Changed 4 years ago by Daniel Ursache-Dogariu

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedFixed on a branch

Added validation for

  • normal phone numbers: 0xxxxxxxxx
  • geographic short phone numbers: 0xxxxxx
  • national short phone numbers: 1xx, 1xxxxx

Tests pass under SQLite.

The branch with the changes is on github: https://github.com/danniel/django/tree/ticket_18775

Version 2, edited 4 years ago by Daniel Ursache-Dogariu (previous) (next) (diff)

comment:2 Changed 4 years ago by Aymeric Augustin

Triage Stage: Fixed on a branchUnreviewed

"Fixed on a branch" lost most of its meaning since the move to git, it was for official SVN branches.

comment:3 Changed 4 years ago by Daniel Ursache-Dogariu

Has patch: set

comment:4 Changed 4 years ago by Aymeric Augustin

Keywords: localflavorsplit added
Resolution: invalid
Status: newclosed

django.contrib.localflavor is now deprecated — see https://docs.djangoproject.com/en/dev/ref/contrib/localflavor/

A repository was created for each localflavor at https://github.com/django/django-localflavor-? (Replace with the country code.)

If you're still interested in this ticket, could you create a pull request on that repository?

Sorry for not resolving this issue earlier, and thanks for your input!

Note: See TracTickets for help on using tickets.
Back to Top