id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
17888	CheckboxInput.render() shouldn't catch exceptions from check_test	Bruno Renié	nobody	"https://github.com/django/django/blob/master/django/forms/widgets.py#L502-505

As the docs state, `check_test` is a callable that returns `True` if the checkbox should be checked for a specific value. The default implementation doesn't do anything complicated and shouldn't raise exceptions. If user-provided callables break, it django shouldn't catch the error silently.

My proposal is to simply remove that bare except and let `check_test` raise exceptions.

The current behaviour is actually expected and tested:

https://github.com/django/django/blob/master/tests/regressiontests/forms/tests/widgets.py#L218-224

I still think it's quite a bad API and should be changed. Since that exception-swallowing behaviour isn't documented (although tested), backwards compatibility isn't that much of a concern."	Cleanup/optimization	closed	Forms	dev	Normal	fixed		marc.tamlyn@…	Ready for checkin	1	0	0	0	0	0