Opened 5 years ago

Closed 3 years ago

#17556 closed New feature (duplicate)

Let Media classes to inherit

Reported by: Aleksander Zdyb Owned by: nobody
Component: Forms Version: master
Severity: Normal Keywords: forms media
Cc: d1fffuz0r@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


Media classes in ModelAdmin or Form cannot inherit from other classes:

class BaseMedia:
    css = {"all": ["base.css", ] }

class ExampleAdmin(ModelAdmin):
    class Media(BaseMedia):
        js = ["example.js, ]    

In the example above, only js media will be available. This is because of the following code in django/forms/

class Media(StrAndUnicode):
    def __init__(self, media=None, **kwargs):
        if media:
            media_attrs = media.__dict__
            media_attrs = kwargs

__dict__ doesn't include inherited properties.

My proposal is to use getmembers from inspect module:

media_attrs = dict(getmembers(media))

I've attached a 2-lines patch. All unit tests passed against revision 17377.

Attachments (2)

media_inherit.diff (664 bytes) - added by Aleksander Zdyb 5 years ago.
media_inherit.2.patch (1.7 KB) - added by Roman Gladkov 4 years ago.

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by Aleksander Zdyb

Attachment: media_inherit.diff added

comment:1 Changed 5 years ago by Łukasz Rekucki

Needs documentation: unset
Needs tests: set
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

The patch needs tests.

Changed 4 years ago by Roman Gladkov

Attachment: media_inherit.2.patch added

comment:2 Changed 4 years ago by Roman Gladkov

Cc: d1fffuz0r@… added
Easy pickings: unset
Needs tests: unset

tests for this patch

Version 0, edited 4 years ago by Roman Gladkov (next)

comment:3 Changed 3 years ago by Aymeric Augustin

This is a duplicate of #9357.

comment:4 Changed 3 years ago by Simon Charette

Resolution: duplicate
Status: newclosed
Note: See TracTickets for help on using tickets.
Back to Top